Issue 17826004: Get rid of the ZoneScopeMode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17826004: Get rid of the ZoneScopeMode. (Closed)

Created:
7 years, 6 months ago by Benedikt Meurer

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Get rid of the ZoneScopeMode. No one is using the DONT_DELETE_ON_EXIT mode for ZoneScopes anymore, so we can safely assume that all ZoneScopes are DELETE_ON_EXIT now. R=danno@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15336

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -63 lines)			Patch
M	src/compiler.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/compiler.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/deoptimizer.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/gdb-jit.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen-environment-liveness.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen-gvn.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/json-parser.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/jsregexp.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/liveedit.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/zone.h	View	3 chunks	+1 line, -15 lines	0 comments	Download
M	src/zone-inl.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/cctest/test-ast.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-dataflow.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-liveedit.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-regexp.cc	View	16 chunks	+16 lines, -16 lines	0 comments	Download
M	test/cctest/test-strings.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

7 years, 6 months ago (2013-06-26 12:54:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15336 (presubmit successful).