Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1782583003: Puts the new Material Design User Manager behind a flag (Closed)

Created:
4 years, 9 months ago by Moe
Modified:
4 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Puts the new Material Design User Manager behind a flag Committed: https://crrev.com/4059f332355d7ba51b72e46c589c5c8c7efb65cc Cr-Commit-Position: refs/heads/master@{#380451}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Addressed comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_window.cc View 1 2 chunks +4 lines, -1 line 1 comment Download
M components/signin/core/common/profile_management_switches.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/signin/core/common/profile_management_switches.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M components/signin/core/common/signin_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/signin/core/common/signin_switches.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Moe
Hi Anthony, please review my changes.
4 years, 9 months ago (2016-03-09 21:12:49 UTC) #2
anthonyvd
lgtm % a few nits. Thanks! https://codereview.chromium.org/1782583003/diff/1/chrome/browser/profiles/profile_window.cc File chrome/browser/profiles/profile_window.cc (right): https://codereview.chromium.org/1782583003/diff/1/chrome/browser/profiles/profile_window.cc#newcode9 chrome/browser/profiles/profile_window.cc:9: #include <vector> Do ...
4 years, 9 months ago (2016-03-10 16:01:45 UTC) #3
Alexei Svitkine (slow)
https://codereview.chromium.org/1782583003/diff/1/components/signin/core/common/profile_management_switches.h File components/signin/core/common/profile_management_switches.h (right): https://codereview.chromium.org/1782583003/diff/1/components/signin/core/common/profile_management_switches.h#newcode39 components/signin/core/common/profile_management_switches.h:39: bool IsMDUserManager(); On 2016/03/10 16:01:45, anthonyvd wrote: > I'd ...
4 years, 9 months ago (2016-03-10 16:04:33 UTC) #5
Moe
https://codereview.chromium.org/1782583003/diff/1/chrome/browser/profiles/profile_window.cc File chrome/browser/profiles/profile_window.cc (right): https://codereview.chromium.org/1782583003/diff/1/chrome/browser/profiles/profile_window.cc#newcode9 chrome/browser/profiles/profile_window.cc:9: #include <vector> On 2016/03/10 16:01:44, anthonyvd wrote: > Do ...
4 years, 9 months ago (2016-03-10 18:18:22 UTC) #7
Roger Tawa OOO till Jul 10th
lgtm https://codereview.chromium.org/1782583003/diff/20001/chrome/browser/profiles/profile_window.cc File chrome/browser/profiles/profile_window.cc (right): https://codereview.chromium.org/1782583003/diff/20001/chrome/browser/profiles/profile_window.cc#newcode203 chrome/browser/profiles/profile_window.cc:203: chrome::kChromeUIMdUserManagerUrl : chrome::kChromeUIUserManagerURL; Not part of this CL, ...
4 years, 9 months ago (2016-03-10 18:23:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782583003/20001
4 years, 9 months ago (2016-03-10 18:28:47 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-10 19:57:36 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 19:59:45 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4059f332355d7ba51b72e46c589c5c8c7efb65cc
Cr-Commit-Position: refs/heads/master@{#380451}

Powered by Google App Engine
This is Rietveld 408576698