Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_service_worker_unittest.cc

Issue 178253007: Parse manifest file with app.service_worker.script. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: destructor added Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_service_worker_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_service_worker_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_service_worker_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a6bcbb1cbddb10aeff5e3cc3d4c40db4acd25652
--- /dev/null
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_service_worker_unittest.cc
@@ -0,0 +1,76 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/memory/scoped_ptr.h"
+#include "base/values.h"
+#include "chrome/common/extensions/features/feature_channel.h"
+#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
+#include "extensions/common/constants.h"
+#include "extensions/common/error_utils.h"
+#include "extensions/common/extension.h"
+#include "extensions/common/manifest_constants.h"
+#include "extensions/common/manifest_handlers/background_info.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+
+class ExtensionManifestServiceWorkerTest : public ExtensionManifestTest {};
+
+// Checks that an app manifest with a service_worker key but no script fails.
+TEST_F(ExtensionManifestServiceWorkerTest, ServiceWorkerEmpty) {
+ ManifestFromString manifest(
+ "{"
+ " 'name': '',"
+ " 'manifest_version': 2,"
+ " 'version': '1',"
+ " 'app': {"
+ " 'service_worker': {}"
+ " }"
+ "}");
+ LoadAndExpectError(manifest,
+ manifest_errors::kBackgroundRequiredForPlatformApps);
+}
+
+// Checks that an app manifest with a single script is loaded.
+TEST_F(ExtensionManifestServiceWorkerTest, ServiceWorkerScript) {
+ ManifestFromString manifest(
+ "{"
+ " 'name': '',"
+ " 'manifest_version': 2,"
+ " 'version': '1',"
+ " 'app': {"
+ " 'service_worker': {"
+ " 'script': 'service_worker.js'"
Jeffrey Yasskin 2014/02/28 01:54:37 Can you try one with an empty-but-present script v
scheib 2014/03/03 19:54:00 Done.
+ " }"
+ " }"
+ "}");
+ scoped_refptr<Extension> extension(LoadAndExpectSuccess(manifest));
+ ASSERT_TRUE(extension.get());
+ const std::string script =
+ BackgroundInfo::GetServiceWorkerScript(extension.get());
+ EXPECT_EQ("service_worker.js", script);
+
+ EXPECT_TRUE(BackgroundInfo::HasServiceWorker(extension.get()));
+}
+
+// Checks that an app manifest with service worker and background script fails.
+TEST_F(ExtensionManifestServiceWorkerTest, ServiceWorkerWithBackgroundScript) {
+ ManifestFromString manifest(
+ "{"
+ " 'name': '',"
+ " 'manifest_version': 2,"
+ " 'version': '1',"
+ " 'app': {"
+ " 'service_worker': {"
+ " 'script': 'service_worker.js'"
+ " },"
+ " 'background': {"
+ " 'scripts': [ 'background.js' ]"
+ " }"
+ " }"
+ "}");
+ LoadAndExpectError(manifest, manifest_errors::kInvalidBackgroundCombination);
+}
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698