Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_service_worker_unittest.cc

Issue 178253007: Parse manifest file with app.service_worker.script. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: destructor added Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/memory/scoped_ptr.h"
6 #include "base/values.h"
7 #include "chrome/common/extensions/features/feature_channel.h"
8 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
9 #include "extensions/common/constants.h"
10 #include "extensions/common/error_utils.h"
11 #include "extensions/common/extension.h"
12 #include "extensions/common/manifest_constants.h"
13 #include "extensions/common/manifest_handlers/background_info.h"
14 #include "testing/gtest/include/gtest/gtest.h"
15
16 namespace extensions {
17
18 class ExtensionManifestServiceWorkerTest : public ExtensionManifestTest {};
19
20 // Checks that an app manifest with a service_worker key but no script fails.
21 TEST_F(ExtensionManifestServiceWorkerTest, ServiceWorkerEmpty) {
22 ManifestFromString manifest(
23 "{"
24 " 'name': '',"
25 " 'manifest_version': 2,"
26 " 'version': '1',"
27 " 'app': {"
28 " 'service_worker': {}"
29 " }"
30 "}");
31 LoadAndExpectError(manifest,
32 manifest_errors::kBackgroundRequiredForPlatformApps);
33 }
34
35 // Checks that an app manifest with a single script is loaded.
36 TEST_F(ExtensionManifestServiceWorkerTest, ServiceWorkerScript) {
37 ManifestFromString manifest(
38 "{"
39 " 'name': '',"
40 " 'manifest_version': 2,"
41 " 'version': '1',"
42 " 'app': {"
43 " 'service_worker': {"
44 " 'script': 'service_worker.js'"
Jeffrey Yasskin 2014/02/28 01:54:37 Can you try one with an empty-but-present script v
scheib 2014/03/03 19:54:00 Done.
45 " }"
46 " }"
47 "}");
48 scoped_refptr<Extension> extension(LoadAndExpectSuccess(manifest));
49 ASSERT_TRUE(extension.get());
50 const std::string script =
51 BackgroundInfo::GetServiceWorkerScript(extension.get());
52 EXPECT_EQ("service_worker.js", script);
53
54 EXPECT_TRUE(BackgroundInfo::HasServiceWorker(extension.get()));
55 }
56
57 // Checks that an app manifest with service worker and background script fails.
58 TEST_F(ExtensionManifestServiceWorkerTest, ServiceWorkerWithBackgroundScript) {
59 ManifestFromString manifest(
60 "{"
61 " 'name': '',"
62 " 'manifest_version': 2,"
63 " 'version': '1',"
64 " 'app': {"
65 " 'service_worker': {"
66 " 'script': 'service_worker.js'"
67 " },"
68 " 'background': {"
69 " 'scripts': [ 'background.js' ]"
70 " }"
71 " }"
72 "}");
73 LoadAndExpectError(manifest, manifest_errors::kInvalidBackgroundCombination);
74 }
75
76 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698