Parse manifest file with app.service_worker.script.

chrome/common/extensions/manifest_tests/extension_manifests_service_worker_unittest.cc

Index: chrome/common/extensions/manifest_tests/extension_manifests_service_worker_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_service_worker_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_service_worker_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b6aaff2acdaabec6e515a055c17bb3d0dd55ed85
--- /dev/null
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_service_worker_unittest.cc
@@ -0,0 +1,131 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/command_line.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/test/values_test_util.h"
+#include "base/values.h"
+#include "chrome/common/extensions/features/feature_channel.h"
+#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
+#include "content/public/common/content_switches.h"
+#include "extensions/common/constants.h"
+#include "extensions/common/error_utils.h"
+#include "extensions/common/extension.h"
+#include "extensions/common/manifest_constants.h"
+#include "extensions/common/manifest_handlers/background_info.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+
+class ExtensionManifestServiceWorkerTest : public ExtensionManifestTest {};
+
+// Checks that a service_worker key is ignored without enable-service-worker
+// switch.
+TEST_F(ExtensionManifestServiceWorkerTest, ServiceWorkerCommandLineRequired) {
+  CHECK(!CommandLine::ForCurrentProcess()->HasSwitch(
+      ::switches::kEnableServiceWorker));
+  const char* manifest_string =
+      "{"
+      "  'name': '',"
+      "  'manifest_version': 2,"
+      "  'version': '1',"
+      "  'app': {"
+      "    'service_worker': {"
+      "      'script': 'service_worker.js'"
+      "    }"
+      "  }"
+      "}";
+  LoadAndExpectError(Manifest(base::test::ParseJsonDictionaryWithSingleQuotes(
+                                  manifest_string).Pass()),
+                     manifest_errors::kServiceWorkerRequiresFlag);
+}
+
+// Checks that an app manifest with a service_worker key but no script fails.
+TEST_F(ExtensionManifestServiceWorkerTest, ServiceWorkerEmpty) {
+  CHECK(!CommandLine::ForCurrentProcess()->HasSwitch(
+      ::switches::kEnableServiceWorker));
+  CommandLine::ForCurrentProcess()->AppendSwitch(
+      switches::kEnableServiceWorker);
+  const char* manifest_string =
+      "{"
+      "  'name': '',"
+      "  'manifest_version': 2,"
+      "  'version': '1',"
+      "  'app': {"
+      "    'service_worker': {}"  // No script specified.
+      "  }"
+      "}";
+  LoadAndExpectError(Manifest(base::test::ParseJsonDictionaryWithSingleQuotes(
+                                  manifest_string).Pass()),
+                     manifest_errors::kBackgroundRequiredForPlatformApps);
+
+  const char* manifest_string2 =
+      "{"
+      "  'name': '',"
+      "  'manifest_version': 2,"
+      "  'version': '1',"
+      "  'app': {"
+      "    'service_worker': {"
+      "      'script': ''"  // Empty script.
+      "    }"
+      "  }"
+      "}";
+  LoadAndExpectError(Manifest(base::test::ParseJsonDictionaryWithSingleQuotes(
+                                  manifest_string2).Pass()),
+                     manifest_errors::kBackgroundRequiredForPlatformApps);
+}
+
+// Checks that an app manifest with a single script is loaded.
+TEST_F(ExtensionManifestServiceWorkerTest, ServiceWorkerScript) {
+  CHECK(!CommandLine::ForCurrentProcess()->HasSwitch(
+      ::switches::kEnableServiceWorker));
+  CommandLine::ForCurrentProcess()->AppendSwitch(
+      switches::kEnableServiceWorker);
+  const char* manifest_string =
+      "{"
+      "  'name': '',"
+      "  'manifest_version': 2,"
+      "  'version': '1',"
+      "  'app': {"
+      "    'service_worker': {"
+      "      'script': 'service_worker.js'"
+      "    }"
+      "  }"
+      "}";
+  scoped_refptr<Extension> extension(LoadAndExpectSuccess(
+      Manifest(base::test::ParseJsonDictionaryWithSingleQuotes(manifest_string)
+                   .Pass())));

[Jeffrey Yasskin, 2014/03/04 17:29:16]

You probably don't need a .Pass() here, since the scoped_ptr is a temporary.

[scheib, 2014/03/04 17:51:24]

Done.

+  ASSERT_TRUE(extension.get());
+  EXPECT_EQ("service_worker.js",
+            BackgroundInfo::GetServiceWorkerScript(extension.get()));
+
+  EXPECT_TRUE(BackgroundInfo::HasServiceWorker(extension.get()));
+}
+
+// Checks that an app manifest with service worker and background script fails.
+TEST_F(ExtensionManifestServiceWorkerTest, ServiceWorkerWithBackgroundScript) {
+  CHECK(!CommandLine::ForCurrentProcess()->HasSwitch(
+      ::switches::kEnableServiceWorker));
+  CommandLine::ForCurrentProcess()->AppendSwitch(
+      switches::kEnableServiceWorker);
+  const char* manifest_string =
+      "{"
+      "  'name': '',"
+      "  'manifest_version': 2,"
+      "  'version': '1',"
+      "  'app': {"
+      "    'service_worker': {"
+      "      'script': 'service_worker.js'"
+      "    },"
+      "    'background': {"
+      "      'scripts': [ 'background.js' ]"
+      "    }"
+      "  }"
+      "}";
+  LoadAndExpectError(Manifest(base::test::ParseJsonDictionaryWithSingleQuotes(
+                                  manifest_string).Pass()),
+                     manifest_errors::kInvalidBackgroundCombination);
+}
+
+}  // namespace extensions