chrome/common/extensions/manifest_tests/extension_manifest_test.cc - Issue 178253007: Parse manifest file with app.service_worker.script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifest_test.cc

Issue 178253007: Parse manifest file with app.service_worker.script. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/manifest_tests/extension_manifest_test.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifest_test.cc b/chrome/common/extensions/manifest_tests/extension_manifest_test.cc

index 845bf0a06a58b7d6f9040060093b93447d73602e..af8198a98355a133f07da5cb14a0cb7cbcc920b6 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifest_test.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifest_test.cc

@@ -67,6 +67,12 @@ ExtensionManifestTest::Manifest::Manifest(base::DictionaryValue* manifest,

CHECK(manifest_) << "Manifest NULL";

}

+ExtensionManifestTest::Manifest::Manifest(

+ scoped_ptr<base::DictionaryValue> manifest)

+ : manifest_(manifest.get()), manifest_holder_(manifest.Pass()) {

+ CHECK(manifest_) << "Manifest NULL";

ExtensionManifestTest::Manifest::Manifest(const Manifest& m) {

NOTREACHED();

}