Parse manifest file with app.service_worker.script.

chrome/common/extensions/manifest_tests/extension_manifest_test.h

Index: chrome/common/extensions/manifest_tests/extension_manifest_test.h
diff --git a/chrome/common/extensions/manifest_tests/extension_manifest_test.h b/chrome/common/extensions/manifest_tests/extension_manifest_test.h
index d7169437cb4fb525a8747fef933662ee83ea04d7..936a45a08a02db8a825e1d66c6fa62877aaa096d 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifest_test.h
+++ b/chrome/common/extensions/manifest_tests/extension_manifest_test.h
@@ -24,6 +24,7 @@ class ExtensionManifestTest : public testing::Test {
    public:
     explicit Manifest(const char* name);
     Manifest(base::DictionaryValue* manifest, const char* name);
+    Manifest(scoped_ptr<base::DictionaryValue> manifest, const char* name);

[Jeffrey Yasskin, 2014/03/04 01:41:48]

All of the uses of this constructor pass "" for the name, so consider removing
the parameter.

[scheib, 2014/03/04 15:34:31]

Done.

     // C++98 requires the copy constructor for a type to be visible if you
     // take a const-ref of a temporary for that type.  Since Manifest
     // contains a scoped_ptr, its implicit copy constructor is declared
@@ -42,7 +43,7 @@ class ExtensionManifestTest : public testing::Test {
     base::DictionaryValue* GetManifest(char const* test_data_dir,
                                        std::string* error) const;
 
-   private:
+   protected:

[Jeffrey Yasskin, 2014/03/04 01:41:48]

I think this can go back to "private".

[scheib, 2014/03/04 15:34:31]

Done.

     const std::string name_;
     mutable base::DictionaryValue* manifest_;
     mutable scoped_ptr<base::DictionaryValue> manifest_holder_;