Parse manifest file with app.service_worker.script.

chrome/common/extensions/manifest_tests/extension_manifest_test.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_TESTS_EXTENSION_MANIFEST_TEST_H_
 #define CHROME_COMMON_EXTENSIONS_MANIFEST_TESTS_EXTENSION_MANIFEST_TEST_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
 #include "chrome/common/extensions/features/feature_channel.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 class ExtensionManifestTest : public testing::Test {
  public:
   ExtensionManifestTest();
 
  protected:
   // Helper class that simplifies creating methods that take either a filename
   // to a manifest or the manifest itself.
   class Manifest {
    public:
     explicit Manifest(const char* name);
     Manifest(base::DictionaryValue* manifest, const char* name);
+    Manifest(scoped_ptr<base::DictionaryValue> manifest, const char* name);

[Jeffrey Yasskin, 2014/03/04 01:41:48]

All of the uses of this constructor pass "" for the name, so consider removing
the parameter.

[scheib, 2014/03/04 15:34:31]

Done.

     // C++98 requires the copy constructor for a type to be visible if you
     // take a const-ref of a temporary for that type.  Since Manifest
     // contains a scoped_ptr, its implicit copy constructor is declared
     // Manifest(Manifest&) according to spec 12.8.5.  This breaks the first
     // requirement and thus you cannot use it with LoadAndExpectError() or
     // LoadAndExpectSuccess() easily.
     //
     // To get around this spec pedantry, we declare the copy constructor
     // explicitly.  It will never get invoked.
     Manifest(const Manifest& m);
 
     ~Manifest();
 
     const std::string& name() const { return name_; };
 
     base::DictionaryValue* GetManifest(char const* test_data_dir,
                                        std::string* error) const;
 
-   private:
+   protected:

[Jeffrey Yasskin, 2014/03/04 01:41:48]

I think this can go back to "private".

[scheib, 2014/03/04 15:34:31]

Done.

     const std::string name_;
     mutable base::DictionaryValue* manifest_;
     mutable scoped_ptr<base::DictionaryValue> manifest_holder_;
   };
 
   // The subdirectory in which to find test data files.
   virtual char const* test_data_dir();
 
   scoped_ptr<base::DictionaryValue> LoadManifest(
       char const* manifest_name,
@@ skipping 89 matching lines @@
   // Force the manifest tests to run as though they are on trunk, since several
   // tests rely on manifest features being available that aren't on
   // stable/beta.
   //
   // These objects nest, so if a test wants to explicitly test the behaviour
   // on stable or beta, declare it inside that test.
   extensions::ScopedCurrentChannel current_channel_;
 };
 
 #endif  // CHROME_COMMON_EXTENSIONS_MANIFEST_TESTS_EXTENSION_MANIFEST_TEST_H_