Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifest_test.cc

Issue 178253007: Parse manifest file with app.service_worker.script. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifest_test.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifest_test.cc b/chrome/common/extensions/manifest_tests/extension_manifest_test.cc
index 845bf0a06a58b7d6f9040060093b93447d73602e..a1ea67130cb359abfe994fbef954574f23e0ce46 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifest_test.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifest_test.cc
@@ -4,9 +4,12 @@
#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
+#include <algorithm>
Jeffrey Yasskin 2014/03/04 01:41:48 You don't use these new #includes anymore.
scheib 2014/03/04 15:34:31 Done.
+
#include "base/file_util.h"
#include "base/files/file_path.h"
#include "base/json/json_file_value_serializer.h"
+#include "base/json/json_string_value_serializer.h"
#include "base/path_service.h"
#include "base/values.h"
#include "chrome/common/chrome_paths.h"
@@ -67,6 +70,15 @@ ExtensionManifestTest::Manifest::Manifest(base::DictionaryValue* manifest,
CHECK(manifest_) << "Manifest NULL";
}
+ExtensionManifestTest::Manifest::Manifest(
+ scoped_ptr<base::DictionaryValue> manifest,
+ const char* name)
+ : name_(name),
+ manifest_(manifest.get()),
+ manifest_holder_(manifest.Pass()) {
+ CHECK(manifest_) << "Manifest NULL";
+}
+
ExtensionManifestTest::Manifest::Manifest(const Manifest& m) {
NOTREACHED();
}

Powered by Google App Engine
This is Rietveld 408576698