Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1509)

Side by Side Diff: src/common/windows/pdb_source_line_writer.cc

Issue 1782453003: Windows dump_syms: Add unittest for a PDB containing PDATA/XDATA Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@pdb-pdata
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/tools/windows/dump_syms/dump_syms_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006, Google Inc. 1 // Copyright (c) 2006, Google Inc.
2 // All rights reserved. 2 // All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // * Redistributions of source code must retain the above copyright 8 // * Redistributions of source code must retain the above copyright
9 // notice, this list of conditions and the following disclaimer. 9 // notice, this list of conditions and the following disclaimer.
10 // * Redistributions in binary form must reproduce the above 10 // * Redistributions in binary form must reproduce the above
(...skipping 1363 matching lines...) Expand 10 before | Expand all | Expand 10 after
1374 1374
1375 return true; 1375 return true;
1376 } 1376 }
1377 1377
1378 bool PDBSourceLineWriter::GetPEInfo(PEModuleInfo *info) { 1378 bool PDBSourceLineWriter::GetPEInfo(PEModuleInfo *info) {
1379 if (!info) { 1379 if (!info) {
1380 return false; 1380 return false;
1381 } 1381 }
1382 1382
1383 if (code_file_.empty() && !FindPEFile()) { 1383 if (code_file_.empty() && !FindPEFile()) {
1384 fprintf(stderr, "Couldn't locate EXE or DLL file.\n");
1385 return false; 1384 return false;
1386 } 1385 }
1387 1386
1388 // Convert wchar to native charset because ImageLoad only takes 1387 // Convert wchar to native charset because ImageLoad only takes
1389 // a PSTR as input. 1388 // a PSTR as input.
1390 string code_file; 1389 string code_file;
1391 if (!WindowsStringUtils::safe_wcstombs(code_file_, &code_file)) { 1390 if (!WindowsStringUtils::safe_wcstombs(code_file_, &code_file)) {
1392 return false; 1391 return false;
1393 } 1392 }
1394 1393
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
1451 // an old-style CodeView record if a real 128-bit GUID has its first 32 1450 // an old-style CodeView record if a real 128-bit GUID has its first 32
1452 // bits set the same as the module's signature (timestamp) and the rest of 1451 // bits set the same as the module's signature (timestamp) and the rest of
1453 // the GUID is set to 0. This is highly unlikely. 1452 // the GUID is set to 0. This is highly unlikely.
1454 1453
1455 GUID signature_guid = {signature}; // 0-initializes other members 1454 GUID signature_guid = {signature}; // 0-initializes other members
1456 *uses_guid = !IsEqualGUID(guid, signature_guid); 1455 *uses_guid = !IsEqualGUID(guid, signature_guid);
1457 return true; 1456 return true;
1458 } 1457 }
1459 1458
1460 } // namespace google_breakpad 1459 } // namespace google_breakpad
OLDNEW
« no previous file with comments | « no previous file | src/tools/windows/dump_syms/dump_syms_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698