Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/example.expected/invalid_config.json

Issue 1782333002: Add bisect config validation. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Rebased Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect/example.expected/invalid_config.json
diff --git a/scripts/slave/recipe_modules/auto_bisect/example.expected/invalid_config.json b/scripts/slave/recipe_modules/auto_bisect/example.expected/invalid_config.json
new file mode 100644
index 0000000000000000000000000000000000000000..5a89f410482238c127b968794bc40c8040d6e83f
--- /dev/null
+++ b/scripts/slave/recipe_modules/auto_bisect/example.expected/invalid_config.json
@@ -0,0 +1,66 @@
+[
+ {
+ "cmd": [
+ "git",
+ "update-ref",
+ "refs/heads/master",
+ "refs/remotes/origin/master"
+ ],
+ "cwd": "[TMP_BASE]/fake_checkout_tmp_1",
+ "name": "git update-ref"
+ },
+ {
+ "cmd": [
+ "git",
+ "checkout",
+ "master"
+ ],
+ "cwd": "[TMP_BASE]/fake_checkout_tmp_1",
+ "name": "git checkout"
+ },
+ {
+ "cmd": [],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "config",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@Bisect job configuration@{@@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"bad_revision\": \"314017\", @@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"bug_id\": \"-1\", @@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"builder_host\": \"master4.golo.chromium.org\", @@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"builder_port\": \"8341\", @@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"bypass_stats_check\": \"True\", @@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"command\": \"src/tools/perf/run_benchmark -v --browser=release smoothness.tough_scrolling_cases\", @@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"dummy_builds\": \"True\", @@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"dummy_job_names\": \"True\", @@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"good_revision\": \"not a valid revision\", @@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"gs_bucket\": \"chrome-perf\", @@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"max_time_minutes\": \"5\", @@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"metric\": \"mean_input_event_latency/mean_input_event_latency\", @@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"recipe_tester_name\": \"linux_perf_tester\", @@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"repeat_count\": \"2\", @@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"skip_gclient_ops\": \"True\", @@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"test_type\": \"perf\"@@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@}@@@",
+ "@@@STEP_LOG_END@Bisect job configuration@@@",
+ "@@@SET_BUILD_PROPERTY@extra_result_code@[\"B4T_BAD_CONFIG\"]@@@"
+ ]
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "import sys; sys.exit(1)"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "Recipe failed. Reason: Invalid value 'not a valid revision' for \"good_revision\".",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@python.inline@import sys; sys.exit(1)@@@",
+ "@@@STEP_LOG_END@python.inline@@@"
+ ]
+ },
+ {
+ "name": "$result",
+ "reason": "Invalid value 'not a valid revision' for \"good_revision\".",
+ "status_code": 1
+ }
+]

Powered by Google App Engine
This is Rietveld 408576698