scripts/slave/recipe_modules/auto_bisect/example.expected/invalid_config.json - Issue 1782333002: Add bisect config validation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipe_modules/auto_bisect/example.expected/invalid_config.json

Issue 1782333002: Add bisect config validation. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Rebased Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/example.expected/failed_test.json ('k') | scripts/slave/recipe_modules/auto_bisect/example.expected/mac_bisector.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 [

	2 {

	3 "cmd": [

	4 "git",

	5 "update-ref",

	6 "refs/heads/master",

	7 "refs/remotes/origin/master"

	8 ],

	9 "cwd": "[TMP_BASE]/fake_checkout_tmp_1",

	10 "name": "git update-ref"

	11 },

	12 {

	13 "cmd": [

	14 "git",

	15 "checkout",

	16 "master"

	17 ],

	18 "cwd": "[TMP_BASE]/fake_checkout_tmp_1",

	19 "name": "git checkout"

	20 },

	21 {

	22 "cmd": [],

	23 "cwd": "[SLAVE_BUILD]",

	24 "name": "config",

	25 "~followup_annotations": [

	26 "@@@STEP_LOG_LINE@Bisect job configuration@{@@@",

	27 "@@@STEP_LOG_LINE@Bisect job configuration@ \"bad_revision\": \"314017\", @@@",

	28 "@@@STEP_LOG_LINE@Bisect job configuration@ \"bug_id\": \"-1\", @@@",

	29 "@@@STEP_LOG_LINE@Bisect job configuration@ \"builder_host\": \"master4.g olo.chromium.org\", @@@",

	30 "@@@STEP_LOG_LINE@Bisect job configuration@ \"builder_port\": \"8341\", @ @@",

	31 "@@@STEP_LOG_LINE@Bisect job configuration@ \"bypass_stats_check\": \"Tru e\", @@@",

	32 "@@@STEP_LOG_LINE@Bisect job configuration@ \"command\": \"src/tools/perf /run_benchmark -v --browser=release smoothness.tough_scrolling_cases\", @@@",

	33 "@@@STEP_LOG_LINE@Bisect job configuration@ \"dummy_builds\": \"True\", @ @@",

	34 "@@@STEP_LOG_LINE@Bisect job configuration@ \"dummy_job_names\": \"True\" , @@@",

	35 "@@@STEP_LOG_LINE@Bisect job configuration@ \"good_revision\": \"not a va lid revision\", @@@",

	36 "@@@STEP_LOG_LINE@Bisect job configuration@ \"gs_bucket\": \"chrome-perf\ ", @@@",

	37 "@@@STEP_LOG_LINE@Bisect job configuration@ \"max_time_minutes\": \"5\", @@@",

	38 "@@@STEP_LOG_LINE@Bisect job configuration@ \"metric\": \"mean_input_even t_latency/mean_input_event_latency\", @@@",

	39 "@@@STEP_LOG_LINE@Bisect job configuration@ \"recipe_tester_name\": \"lin ux_perf_tester\", @@@",

	40 "@@@STEP_LOG_LINE@Bisect job configuration@ \"repeat_count\": \"2\", @@@" ,

	41 "@@@STEP_LOG_LINE@Bisect job configuration@ \"skip_gclient_ops\": \"True\ ", @@@",

	42 "@@@STEP_LOG_LINE@Bisect job configuration@ \"test_type\": \"perf\"@@@",

	43 "@@@STEP_LOG_LINE@Bisect job configuration@}@@@",

	44 "@@@STEP_LOG_END@Bisect job configuration@@@",

	45 "@@@SET_BUILD_PROPERTY@extra_result_code@[\"B4T_BAD_CONFIG\"]@@@"

	46 ]

	47 },

	48 {

	49 "cmd": [

	50 "python",

	51 "-u",

	52 "import sys; sys.exit(1)"

	53 ],

	54 "cwd": "[SLAVE_BUILD]",

	55 "name": "Recipe failed. Reason: Invalid value 'not a valid revision' for \"g ood_revision\".",

	56 "~followup_annotations": [

	57 "@@@STEP_LOG_LINE@python.inline@import sys; sys.exit(1)@@@",

	58 "@@@STEP_LOG_END@python.inline@@@"

	59 ]

	60 },

	61 {

	62 "name": "$result",

	63 "reason": "Invalid value 'not a valid revision' for \"good_revision\".",

	64 "status_code": 1

	65 }

	66 ]

OLD	NEW