rewrite_to_chrome_style: Blacklist InspectorAgent::disable

rewrite_to_chrome_style: Blacklist InspectorAgent::disable

This method overrides stuff in gen/ and stuff from blink:: and if we
rename it without renaming both we'll break things. So don't rename
it at all.

R=dcheng
BUG=593446
Committed: https://crrev.com/ec30d6b644ed9cd739b3b65efca762e1b1846cfc
Cr-Commit-Position: refs/heads/master@{#380773}

[danakj, 2016-03-11 01:48:46]

Depends on all the other rewriter CLs :)

[dcheng, 2016-03-11 02:01:17]

lgtm

https://codereview.chromium.org/1782293003/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/1782293003/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:133: if
(IsMethodOverrideOf(decl, "blink::InspectorAgent"))
Nit: &&

[danakj, 2016-03-11 02:08:42]

https://codereview.chromium.org/1782293003/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/1782293003/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:133: if
(IsMethodOverrideOf(decl, "blink::InspectorAgent"))
On 2016/03/11 02:01:17, dcheng wrote:
> Nit: &&

Ohh ya :) Done.

[danakj, 2016-03-11 20:42:52]

Rebased onto isBlacklistedMethod, but no changes were required here.

[dcheng, 2016-03-11 20:49:02]

still lgtm

[danakj, 2016-03-11 21:25:35]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-11 21:25:36]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1782293003/#ps60001
(title: "rewrite-blacklist-inspector: rebase")

[commit-bot: I haz the power, 2016-03-11 21:26:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782293003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782293003/60001

[commit-bot: I haz the power, 2016-03-11 23:00:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-11 23:02:38]

Description was changed from

==========
rewrite_to_chrome_style: Blacklist InspectorAgent::disable

This method overrides stuff in gen/ and stuff from blink:: and if we
rename it without renaming both we'll break things. So don't rename
it at all.

R=dcheng
BUG=593446
==========

to

==========
rewrite_to_chrome_style: Blacklist InspectorAgent::disable

This method overrides stuff in gen/ and stuff from blink:: and if we
rename it without renaming both we'll break things. So don't rename
it at all.

R=dcheng
BUG=593446

Committed: https://crrev.com/ec30d6b644ed9cd739b3b65efca762e1b1846cfc
Cr-Commit-Position: refs/heads/master@{#380773}
==========

[commit-bot: I haz the power, 2016-03-11 23:02:40]

Patchset 4 (id:??) landed as
https://crrev.com/ec30d6b644ed9cd739b3b65efca762e1b1846cfc
Cr-Commit-Position: refs/heads/master@{#380773}