rewrite_to_chrome_style: Blacklist InspectorAgent::disable

tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Changes Blink-style names to Chrome-style names. Currently transforms:
 //   fields:
 //     int m_operationCount => int operation_count_
 //   variables (including parameters):
 //     int mySuperVariable => int my_super_variable
 //   constants:
@@ skipping 69 matching lines @@
 // getAnyMember() will return a FieldDecl which we can match against.
 AST_MATCHER_P(clang::CXXCtorInitializer,
               forAnyField,
               clang::ast_matchers::internal::Matcher<clang::FieldDecl>,
               InnerMatcher) {
   const clang::FieldDecl* NodeAsDecl = Node.getAnyMember();
   return (NodeAsDecl != nullptr &&
           InnerMatcher.matches(*NodeAsDecl, Finder, Builder));
 }
 
+bool IsMethodOverrideOf(const clang::CXXMethodDecl& decl,
+                        const char* class_name) {
+  if (decl.getParent()->getQualifiedNameAsString() == class_name)
+    return true;
+  for (auto it = decl.begin_overridden_methods();
+       it != decl.end_overridden_methods(); ++it) {
+    if (IsMethodOverrideOf(**it, class_name))
+      return true;
+  }
+  return false;
+}
+
 bool IsBlacklistedMethod(const clang::CXXMethodDecl& decl) {
   if (decl.isStatic())
     return false;
 
   clang::StringRef name = decl.getName();
 
   // These methods should never be renamed.
   static const char* kBlacklistMethods[] = {"trace", "lock", "unlock",
                                             "try_lock"};
   for (const auto& b : kBlacklistMethods) {
     if (name == b)
       return true;
   }
 
   // Iterator methods shouldn't be renamed to work with stl and range-for
   // loops.
   std::string ret_type = decl.getReturnType().getAsString();
-  if (ret_type.find("iterator") == std::string::npos &&
-      ret_type.find("Iterator") == std::string::npos)
-    return false;
-  static const char* kIteratorBlacklist[] = {"begin", "end", "rbegin", "rend"};
-  for (const auto& b : kIteratorBlacklist) {
-    if (name == b)
+  if (ret_type.find("iterator") != std::string::npos ||
+      ret_type.find("Iterator") != std::string::npos) {
+    static const char* kIteratorBlacklist[] = {"begin", "end", "rbegin",
+                                               "rend"};
+    for (const auto& b : kIteratorBlacklist) {
+      if (name == b)
+        return true;
+    }
+  }
+
+  // Subclasses of InspectorAgent will subclass "disable()" from both blink and
+  // from gen/, which is problematic, but DevTools folks don't want to rename
+  // it or split this up. So don't rename it at all.
+  if (name.equals("disable")) {
+    if (IsMethodOverrideOf(decl, "blink::InspectorAgent"))

[dcheng, 2016/03/11 02:01:17]

Nit: &&

[danakj, 2016/03/11 02:08:42]

Ohh ya :) Done.

       return true;
   }
 
   return false;
 }
 
 bool IsDeclContextInBlinkOrWTF(const clang::DeclContext* decl_context,
                                const clang::SourceLocation& location,
                                clang::SourceManager& source_manager,
                                bool blink,
@@ skipping 679 matching lines @@
   for (const auto& r : replacements) {
     std::string replacement_text = r.getReplacementText().str();
     std::replace(replacement_text.begin(), replacement_text.end(), '\n', '\0');
     llvm::outs() << "r:::" << r.getFilePath() << ":::" << r.getOffset()
                  << ":::" << r.getLength() << ":::" << replacement_text << "\n";
   }
   llvm::outs() << "==== END EDITS ====\n";
 
   return 0;
 }