[Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions

chrome/browser/ui/views/toolbar/app_menu.cc

Index: chrome/browser/ui/views/toolbar/app_menu.cc
diff --git a/chrome/browser/ui/views/toolbar/app_menu.cc b/chrome/browser/ui/views/toolbar/app_menu.cc
index 092007077fda43c58a8734a1b019b588f79fb734..41a134aabc61f1be938c3349f93e3e6c2cc4f6d1 100644
--- a/chrome/browser/ui/views/toolbar/app_menu.cc
+++ b/chrome/browser/ui/views/toolbar/app_menu.cc
@@ -1153,11 +1153,6 @@ void AppMenu::PopulateMenu(MenuItemView* parent, MenuModel* model) {
       case IDC_EXTENSIONS_OVERFLOW_MENU: {
         scoped_ptr<ExtensionToolbarMenuView> extension_toolbar(
             new ExtensionToolbarMenuView(browser_, this, item));
-        if (!extension_toolbar->ShouldShow()) {

[Devlin, 2016/03/11 00:07:25]

This should be unnecessary with ToolbarActionsBar::NeedsOverflow(), which is
what determines whether or not we add the IDC_EXTENSIONS_OVERFLOW_MENU item to
the model.

-          item->SetVisible(false);
-          extension_toolbar_ = nullptr;
-          break;
-        }
         if (ui::MaterialDesignController::IsModeMaterial()) {
           for (int i = 0; i < extension_toolbar->contents()->child_count();
                ++i) {