MD Settings: Certificate manager, password encryption dialog.

chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
index 797b51a093ea7e632d83a06e73e3a8058090d4b3..78827478e334b3fcc08156d8d90934d1c7b3eeaa 100644
--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
@@ -217,6 +217,15 @@ void AddCertificateManagerStrings(content::WebUIDataSource* html_source) {
        IDS_SETTINGS_CERTIFICATE_MANAGER_DELETE_CA_DESCRIPTION},
       {"certificateManagerDeleteOtherTitle",
        IDS_SETTINGS_CERTIFICATE_MANAGER_DELETE_OTHER_TITLE},
+       // Encrypt password dialog
+      {"certificateManagerEncryptPasswordTitle",
+       IDS_SETTINGS_CERTIFICATE_MANAGER_ENCRYPT_PASSWORD_TITLE},
+      {"certificateManagerEncryptPasswordDescription",
+       IDS_SETTINGS_CERTIFICATE_MANAGER_ENCRYPT_PASSWORD_DESCRIPTION},
+      {"certificateManagerPasswordLabel",
+       IDS_SETTINGS_CERTIFICATE_MANAGER_PASSWORD_LABEL},
+      {"certificateManagerConfirmPasswordLabel",

[dschuyler, 2016/03/11 21:18:15]

Please try for labels that are close to the
English i18n string.  e.g. "confirmPassword".
If the string particularly long, maybe shorten
to the essence of the sentence.

[dpapad, 2016/03/14 19:34:50]

loadTimeData is a flat hashmap (no hierarchy). Collisions become more likely by
removing "namespace" information from the name ("certificateManager"), and the
worst part in this case (unlike IDS_FOO) is that there is no compile-time error
if loadTimeData collisions happen. I am trying to avoid that, by prefixing with
certificateManager.

[dschuyler, 2016/03/14 21:20:13]

Ah, that makes sense.  Maybe just scratch out the "Label" suffix?
Assuming that the prefix is enough to give the context (avoid 
collisions).

[dpapad, 2016/03/15 01:18:17]

Done. Removed the "Label" suffix.

+       IDS_SETTINGS_CERTIFICATE_MANAGER_CONFIRM_PASSWORD_LABEL},
   };
   AddLocalizedStringsBulk(html_source, localized_strings,
                           arraysize(localized_strings));