MD Settings: Certificate manager, password encryption dialog.

chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.h"
 
 #include <string>
 
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
@@ skipping 199 matching lines @@
       {"certificateManagerDeleteServerTitle",
        IDS_SETTINGS_CERTIFICATE_MANAGER_DELETE_SERVER_TITLE},
       {"certificateManagerDeleteServerDescription",
        IDS_SETTINGS_CERTIFICATE_MANAGER_DELETE_SERVER_DESCRIPTION},
       {"certificateManagerDeleteCaTitle",
        IDS_SETTINGS_CERTIFICATE_MANAGER_DELETE_CA_TITLE},
       {"certificateManagerDeleteCaDescription",
        IDS_SETTINGS_CERTIFICATE_MANAGER_DELETE_CA_DESCRIPTION},
       {"certificateManagerDeleteOtherTitle",
        IDS_SETTINGS_CERTIFICATE_MANAGER_DELETE_OTHER_TITLE},
+       // Encrypt password dialog
+      {"certificateManagerEncryptPasswordTitle",
+       IDS_SETTINGS_CERTIFICATE_MANAGER_ENCRYPT_PASSWORD_TITLE},
+      {"certificateManagerEncryptPasswordDescription",
+       IDS_SETTINGS_CERTIFICATE_MANAGER_ENCRYPT_PASSWORD_DESCRIPTION},
+      {"certificateManagerPasswordLabel",
+       IDS_SETTINGS_CERTIFICATE_MANAGER_PASSWORD_LABEL},
+      {"certificateManagerConfirmPasswordLabel",

[dschuyler, 2016/03/11 21:18:15]

Please try for labels that are close to the
English i18n string.  e.g. "confirmPassword".
If the string particularly long, maybe shorten
to the essence of the sentence.

[dpapad, 2016/03/14 19:34:50]

loadTimeData is a flat hashmap (no hierarchy). Collisions become more likely by
removing "namespace" information from the name ("certificateManager"), and the
worst part in this case (unlike IDS_FOO) is that there is no compile-time error
if loadTimeData collisions happen. I am trying to avoid that, by prefixing with
certificateManager.

[dschuyler, 2016/03/14 21:20:13]

Ah, that makes sense.  Maybe just scratch out the "Label" suffix?
Assuming that the prefix is enough to give the context (avoid 
collisions).

[dpapad, 2016/03/15 01:18:17]

Done. Removed the "Label" suffix.

+       IDS_SETTINGS_CERTIFICATE_MANAGER_CONFIRM_PASSWORD_LABEL},
   };
   AddLocalizedStringsBulk(html_source, localized_strings,
                           arraysize(localized_strings));
 }
 
 void AddClearBrowsingDataStrings(content::WebUIDataSource* html_source) {
   LocalizedString localized_strings[] = {
       {"clearFollowingItemsFrom", IDS_SETTINGS_CLEAR_FOLLOWING_ITEMS_FROM},
       {"clearBrowsingHistory", IDS_SETTINGS_CLEAR_BROWSING_HISTORY},
       {"clearDownloadHistory", IDS_SETTINGS_CLEAR_DOWNLOAD_HISTORY},
@@ skipping 595 matching lines @@
 #endif
   AddUsersStrings(html_source);
   AddWebContentStrings(html_source);
 
   policy_indicator::AddLocalizedStrings(html_source);
 
   html_source->SetJsonPath(kLocalizedStringsFile);
 }
 
 }  // namespace settings