content: Rename virtual method on RenderView to not (ab)use blink style

content: Rename virtual method on RenderView to not (ab)use blink style

The RenderView::convertViewportToWindow method uses blink style to
create a horrorshow inheritance hierarchy problem, where the same
named method in RenderViewImpl inherits this method from two places
(one in blink one in content) from RenderView and from RenderWidget.

Fix this by renaming the method on RenderView to not use the same
name as the blink method (even after blink uses chromium style).

R=avi@chromium.org,jochen@chromium.org
BUG=593446
Committed: https://crrev.com/dea2efb645e7ac6bae644658f963b096c2800652
Cr-Commit-Position: refs/heads/master@{#380441}

[danakj, 2016-03-09 23:17:24]

https://codereview.chromium.org/1781873002/diff/1/content/renderer/render_vie...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/1781873002/diff/1/content/renderer/render_vie...
content/renderer/render_view_impl.cc:2191: convertViewportToWindow(rect);
In future, this could be GetWidget()->convert...() if this class stops
inheriting from RenderWidget.

https://codereview.chromium.org/1781873002/diff/1/extensions/renderer/extensi...
File extensions/renderer/extension_helper.cc (right):

https://codereview.chromium.org/1781873002/diff/1/extensions/renderer/extensi...
extensions/renderer/extension_helper.cc:50:
render_view()->ConvertViewportToWindowViaWidget(&webregions[i].bounds);
I was going to just make all the calls do GetWidget()->convert...() except this
callsite needs the method to be exposed in content/public/, so I left it in the
RenderView API still.

[danakj, 2016-03-10 02:04:22]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-10 02:04:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781873002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781873002/1

[commit-bot: I haz the power, 2016-03-10 03:27:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 03:27:26]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-03-10 04:09:24]

lgtm

[jochen (gone - plz use gerrit), 2016-03-10 15:47:52]

lgtm

[danakj, 2016-03-10 18:59:20]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-03-10 19:00:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781873002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781873002/1

[commit-bot: I haz the power, 2016-03-10 19:13:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-10 19:14:56]

Description was changed from

==========
content: Rename virtual method on RenderView to not (ab)use blink style

The RenderView::convertViewportToWindow method uses blink style to
create a horrorshow inheritance hierarchy problem, where the same
named method in RenderViewImpl inherits this method from two places
(one in blink one in content) from RenderView and from RenderWidget.

Fix this by renaming the method on RenderView to not use the same
name as the blink method (even after blink uses chromium style).

R=avi@chromium.org,jochen@chromium.org
BUG=593446
==========

to

==========
content: Rename virtual method on RenderView to not (ab)use blink style

The RenderView::convertViewportToWindow method uses blink style to
create a horrorshow inheritance hierarchy problem, where the same
named method in RenderViewImpl inherits this method from two places
(one in blink one in content) from RenderView and from RenderWidget.

Fix this by renaming the method on RenderView to not use the same
name as the blink method (even after blink uses chromium style).

R=avi@chromium.org,jochen@chromium.org
BUG=593446

Committed: https://crrev.com/dea2efb645e7ac6bae644658f963b096c2800652
Cr-Commit-Position: refs/heads/master@{#380441}
==========

[commit-bot: I haz the power, 2016-03-10 19:14:57]

Patchset 1 (id:??) landed as
https://crrev.com/dea2efb645e7ac6bae644658f963b096c2800652
Cr-Commit-Position: refs/heads/master@{#380441}