content/renderer/browser_plugin/browser_plugin.cc - Issue 1781873002: content: Rename virtual method on RenderView to not (ab)use blink style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin.cc

Issue 1781873002: content: Rename virtual method on RenderView to not (ab)use blink style (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: renderwidget-overrides Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/browser_plugin/browser_plugin.cc

diff --git a/content/renderer/browser_plugin/browser_plugin.cc b/content/renderer/browser_plugin/browser_plugin.cc

index ac91ef3c73f0ff1f91962535e037b3de3b759763..9a74b59ba05d2fd6e9c6ad7af88ee0704c8c5928 100644

--- a/content/renderer/browser_plugin/browser_plugin.cc

+++ b/content/renderer/browser_plugin/browser_plugin.cc

@@ -416,7 +416,8 @@ void BrowserPlugin::updateGeometry(const WebRect& plugin_rect_in_viewport,

// Convert the plugin_rect_in_viewport to window coordinates, which is css.

WebRect rect_in_css(plugin_rect_in_viewport);

blink::WebView* webview = container()->element().document().frame()->view();

- RenderView::FromWebView(webview)->convertViewportToWindow(&rect_in_css);

+ RenderView::FromWebView(webview)->GetWidget()->convertViewportToWindow(

+ &rect_in_css);

view_rect_ = rect_in_css;

if (!ready_) {

« no previous file with comments | « content/public/renderer/render_view.h ('k') | content/renderer/render_view_impl.h » ('j') | content/renderer/render_view_impl.cc » ('J')