Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1781643003: Mojom parser: Use Encoder.SetDeterministic(true) for stable encodings. (Closed)

Created:
4 years, 9 months ago by rudominer
Modified:
4 years, 9 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojom parser: Use Encoder.SetDeterministic(true) for stable encodings. BUG=#448 R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/81d3e0c3f54517d79bba411fa55a1da3036047d0

Patch Set 1 #

Patch Set 2 : New sha1s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -63 lines) Patch
M mojo/public/tools/bindings/mojom_tool/bin/linux64/mojom.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_parser/generated/mojom_files/mojom_files.mojom.go View 3 chunks +42 lines, -9 lines 0 comments Download
M mojom/mojom_parser/generated/mojom_types/mojom_types.mojom.go View 63 chunks +117 lines, -52 lines 0 comments Download
M mojom/mojom_parser/serialization/serialization.go View 2 chunks +2 lines, -0 lines 0 comments Download
M mojom/mojom_parser/serialization/serialization_test.go View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
rudominer
Hi Alex, ptal.
4 years, 9 months ago (2016-03-09 22:45:42 UTC) #3
azani
lgtm
4 years, 9 months ago (2016-03-09 22:47:12 UTC) #5
rudominer
4 years, 9 months ago (2016-03-09 23:19:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as
81d3e0c3f54517d79bba411fa55a1da3036047d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698