mojom/mojom_parser/serialization/serialization.go - Issue 1781643003: Mojom parser: Use Encoder.SetDeterministic(true) for stable encodings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojom/mojom_parser/serialization/serialization.go

Issue 1781643003: Mojom parser: Use Encoder.SetDeterministic(true) for stable encodings. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: New sha1s Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojom/mojom_parser/generated/mojom_types/mojom_types.mojom.go ('k') | mojom/mojom_parser/serialization/serialization_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojom/mojom_parser/serialization/serialization.go

diff --git a/mojom/mojom_parser/serialization/serialization.go b/mojom/mojom_parser/serialization/serialization.go

index 502dea48e8cfd3aa202c13dbc10f596269f0dd13..498f95ab8283a7bee2fd955c9e561b4c83cd20a4 100644

--- a/mojom/mojom_parser/serialization/serialization.go

+++ b/mojom/mojom_parser/serialization/serialization.go

@@ -52,6 +52,7 @@ func serialize(d *mojom.MojomDescriptor, debug,

debugString = myfmt.Sprintf("%#v", fileGraph)

}

encoder := bindings.NewEncoder()

+ encoder.SetDeterministic(true)

fileGraph.Encode(encoder)

bytes, _, err = encoder.Data()

@@ -207,6 +208,7 @@ func translateMojomFile(f *mojom.MojomFile, fileGraph *mojom_files.MojomFileGrap

// SerializedRuntimeTypeInfo

if emitSerializedRuntimeTypeInfo {

encoder := bindings.NewEncoder()

+ encoder.SetDeterministic(true)

typeInfo.Encode(encoder)

bytes, _, err := encoder.Data()

if err != nil {