Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1781593003: Split off IPDF_SecurityHandler and CPDF_StandardSecurityHandler. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split off IPDF_SecurityHandler and CPDF_StandardSecurityHandler. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ca78d9a5289354f85607f92f68713b25df4fb6ad

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -1154 lines) Patch
M BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 2 chunks +1 line, -119 lines 0 comments Download
A core/include/fpdfapi/ipdf_security_handler.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
A core/src/fpdfapi/fpdf_parser/cpdf_standard_security_handler.h View 1 chunk +105 lines, -0 lines 0 comments Download
A + core/src/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp View 1 5 chunks +13 lines, -342 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp View 2 chunks +1 line, -693 lines 0 comments Download
M pdfium.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Dan, for review.
4 years, 9 months ago (2016-03-09 19:17:47 UTC) #2
dsinclair
lgtm w/ nit. https://codereview.chromium.org/1781593003/diff/1/core/include/fpdfapi/ipdf_security_handler.h File core/include/fpdfapi/ipdf_security_handler.h (right): https://codereview.chromium.org/1781593003/diff/1/core/include/fpdfapi/ipdf_security_handler.h#newcode23 core/include/fpdfapi/ipdf_security_handler.h:23: virtual ~IPDF_SecurityHandler() {} Can you move ...
4 years, 9 months ago (2016-03-09 19:23:14 UTC) #3
Tom Sepez
https://codereview.chromium.org/1781593003/diff/1/core/include/fpdfapi/ipdf_security_handler.h File core/include/fpdfapi/ipdf_security_handler.h (right): https://codereview.chromium.org/1781593003/diff/1/core/include/fpdfapi/ipdf_security_handler.h#newcode23 core/include/fpdfapi/ipdf_security_handler.h:23: virtual ~IPDF_SecurityHandler() {} On 2016/03/09 19:23:13, dsinclair wrote: > ...
4 years, 9 months ago (2016-03-09 19:49:14 UTC) #4
Tom Sepez
4 years, 9 months ago (2016-03-09 19:51:19 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ca78d9a5289354f85607f92f68713b25df4fb6ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698