chrome.browserAction.setBadgeBackgroundColor accepts color keyword

chrome.browserAction.setBadgeBackgroundColor accepts color keyword

Accepts color keyword like 'black', 'blue' from setBadgeBackgroundColor.
Also, if unable to parse color string, returns proper error message

TEST=browser_tests --gtest_filter=BrowserActionApiTest.BadgeBackgroundColor
extensions_unittests --gtest_filter=ImageUtilTest.*

BUG=593194
Committed: https://crrev.com/2fc1c838798d0c76f1c135f1791d3989ab7a2b01
Cr-Commit-Position: refs/heads/master@{#380386}

[limasdf, 2016-03-09 14:20:28]

Description was changed from

==========
chrome.browserAction.setBadgeBackgroundColor accepts color keyword

chrome.browserAction.setBadgeBackgroundColor accepts color keyword

Accepts color keyword like 'black', 'blue' from setBadgeBackgroundColor.
Also, if unable to parse color string, returns proper error message

TEST=browser_tests --gtest_filter=BrowserActionApiTest.BadgeBackgroundColor
extensions_unittests --gtest_filter=ImageUtilTest.*

BUG=593194
==========

to

==========
chrome.browserAction.setBadgeBackgroundColor accepts color keyword

Accepts color keyword like 'black', 'blue' from setBadgeBackgroundColor.
Also, if unable to parse color string, returns proper error message

TEST=browser_tests --gtest_filter=BrowserActionApiTest.BadgeBackgroundColor
extensions_unittests --gtest_filter=ImageUtilTest.*

BUG=593194
==========

[limasdf, 2016-03-09 14:20:28]

limasdf@gmail.com changed reviewers:
+ rdevlin.cronin@chromium.org

[limasdf, 2016-03-09 14:46:49]

Hey Devlin. PTAL when you have time.

[limasdf, 2016-03-09 15:32:35]

One question, Will it be possible to use third_party/Webkit/ 's CSS color
parser? Probably, we shouldn't make a coupling with third_party/WebKit/ ?

[Devlin, 2016-03-09 17:52:20]

lgtm if you wanna go ahead with this.  If you want to explore using the webkit
parser, that's fine too :)

On 2016/03/09 15:32:35, limasdf wrote:
> One question, Will it be possible to use third_party/Webkit/ 's CSS color
> parser? Probably, we shouldn't make a coupling with third_party/WebKit/ ?

It would depend on how much benefit it gives us and how cleanly we can call into
it.  Where's the webkit parser code at?  Have you experimented with using here? 
Technically, extensions/ depends on content/ which in turn depends on WebKit/,
so there's nothing that definitively stops us from using it.

https://codereview.chromium.org/1781563003/diff/1/extensions/common/image_uti...
File extensions/common/image_util.cc (right):

https://codereview.chromium.org/1781563003/diff/1/extensions/common/image_uti...
extensions/common/image_util.cc:33: if
(SkParse::FindNamedColor(color_string.c_str(), color_string.size(),
nifty!

[limasdf, 2016-03-10 09:30:54]

Thanks for the review!

Let's merge. This CL looks enough.

Webkit parser lives in third_party/WebKit/Source/core/css/parser/

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

And there seems no content/ related to that. if we want to use webkit parser, we
should implement content/ and Skia port. it would be a lot of work.

[limasdf, 2016-03-10 09:31:19]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2016-03-10 09:31:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781563003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781563003/1

[commit-bot: I haz the power, 2016-03-10 11:14:41]

Description was changed from

==========
chrome.browserAction.setBadgeBackgroundColor accepts color keyword

Accepts color keyword like 'black', 'blue' from setBadgeBackgroundColor.
Also, if unable to parse color string, returns proper error message

TEST=browser_tests --gtest_filter=BrowserActionApiTest.BadgeBackgroundColor
extensions_unittests --gtest_filter=ImageUtilTest.*

BUG=593194
==========

to

==========
chrome.browserAction.setBadgeBackgroundColor accepts color keyword

Accepts color keyword like 'black', 'blue' from setBadgeBackgroundColor.
Also, if unable to parse color string, returns proper error message

TEST=browser_tests --gtest_filter=BrowserActionApiTest.BadgeBackgroundColor
extensions_unittests --gtest_filter=ImageUtilTest.*

BUG=593194
==========

[commit-bot: I haz the power, 2016-03-10 11:14:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-10 11:15:43]

Description was changed from

==========
chrome.browserAction.setBadgeBackgroundColor accepts color keyword

Accepts color keyword like 'black', 'blue' from setBadgeBackgroundColor.
Also, if unable to parse color string, returns proper error message

TEST=browser_tests --gtest_filter=BrowserActionApiTest.BadgeBackgroundColor
extensions_unittests --gtest_filter=ImageUtilTest.*

BUG=593194
==========

to

==========
chrome.browserAction.setBadgeBackgroundColor accepts color keyword

Accepts color keyword like 'black', 'blue' from setBadgeBackgroundColor.
Also, if unable to parse color string, returns proper error message

TEST=browser_tests --gtest_filter=BrowserActionApiTest.BadgeBackgroundColor
extensions_unittests --gtest_filter=ImageUtilTest.*

BUG=593194

Committed: https://crrev.com/2fc1c838798d0c76f1c135f1791d3989ab7a2b01
Cr-Commit-Position: refs/heads/master@{#380386}
==========

[commit-bot: I haz the power, 2016-03-10 11:15:43]

Patchset 1 (id:??) landed as
https://crrev.com/2fc1c838798d0c76f1c135f1791d3989ab7a2b01
Cr-Commit-Position: refs/heads/master@{#380386}