Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_api.cc

Issue 1781563003: chrome.browserAction.setBadgeBackgroundColor accepts color keyword (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/extension_action_api.cc
diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.cc b/chrome/browser/extensions/api/extension_action/extension_action_api.cc
index b7498659ee36f87fec0951e611516a6fb3a5d70a..4a6ca8d19e5eef34a0c246c1a85a963bba7a8bc8 100644
--- a/chrome/browser/extensions/api/extension_action/extension_action_api.cc
+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.cc
@@ -56,6 +56,8 @@ const char kNoTabError[] = "No tab with id: *.";
const char kOpenPopupError[] =
"Failed to show popup either because there is an existing popup or another "
"error occurred.";
+const char kInvalidColorError[] =
+ "The color specification could not be parsed.";
} // namespace
@@ -580,8 +582,10 @@ bool ExtensionActionSetBadgeBackgroundColorFunction::RunExtensionAction() {
} else if (color_value->IsType(base::Value::TYPE_STRING)) {
std::string color_string;
EXTENSION_FUNCTION_VALIDATE(details_->GetString("color", &color_string));
- if (!image_util::ParseCssColorString(color_string, &color))
+ if (!image_util::ParseCssColorString(color_string, &color)) {
+ error_ = kInvalidColorError;
return false;
+ }
}
extension_action_->SetBadgeBackgroundColor(tab_id_, color);

Powered by Google App Engine
This is Rietveld 408576698