chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm - Issue 1781433002: [Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm

Issue 1781433002: [Reland] Enable AutoResize for Constrained Web Dialogs for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/user_manager_mac.mm ('k') | chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm b/chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm

index 6b1d507a741cf34cb2fa91fc206063b626426c24..4bab88226e16389f4b36d03cce9e126648d0da7f 100644

--- a/chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm

+++ b/chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm

@@ -58,8 +58,10 @@ void SingleWebContentsDialogManagerCocoa::Close() {

[[ConstrainedWindowSheetController controllerForSheet:sheet_]

closeSheet:sheet_];

client_->set_manager(nullptr);

+ bool dialog_was_open = client_->DialogWasShown();

client_->OnDialogClosing(); // |client_| might delete itself here.

- delegate_->WillClose(dialog()); // Deletes |this|.

+ if (dialog_was_open)

+ delegate_->WillClose(dialog()); // Deletes |this|.

}

void SingleWebContentsDialogManagerCocoa::Focus() {