Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1781193004: headless: Make it possible to configure an HTTP proxy (Closed)

Created:
4 years, 9 months ago by Sami
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Make it possible to configure an HTTP proxy Add a configuration option for setting a proxy to be used for all HTTP/HTTPS connections. BUG=546953 Committed: https://crrev.com/f52fa5b3d50f38c0491adc757b05510a2df5ab93 Cr-Commit-Position: refs/heads/master@{#381208}

Patch Set 1 #

Patch Set 2 : Test WIP #

Patch Set 3 : Add tests. #

Patch Set 4 : Finalized test. #

Total comments: 4

Patch Set 5 : Review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -35 lines) Patch
M headless/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M headless/README.md View 1 chunk +5 lines, -3 lines 0 comments Download
M headless/app/headless_shell.cc View 1 2 3 3 chunks +15 lines, -0 lines 0 comments Download
A headless/app/headless_shell_switches.h View 1 chunk +14 lines, -0 lines 0 comments Download
A headless/app/headless_shell_switches.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_context.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_context.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_impl.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_impl.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_url_request_context_getter.cc View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M headless/lib/browser/headless_web_contents_impl.cc View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M headless/lib/headless_browser_browsertest.cc View 1 2 3 2 chunks +39 lines, -0 lines 0 comments Download
M headless/lib/headless_web_contents_browsertest.cc View 1 2 2 chunks +2 lines, -28 lines 0 comments Download
M headless/public/headless_browser.h View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M headless/public/headless_browser.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M headless/public/headless_web_contents.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M headless/test/headless_browser_test.h View 1 2 2 chunks +11 lines, -1 line 0 comments Download
M headless/test/headless_browser_test.cc View 1 2 3 2 chunks +53 lines, -0 lines 0 comments Download
M headless/test/headless_test_launcher.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Sami
4 years, 9 months ago (2016-03-14 14:23:44 UTC) #3
alex clarke (OOO till 29th)
https://codereview.chromium.org/1781193004/diff/60001/headless/lib/browser/headless_url_request_context_getter.cc File headless/lib/browser/headless_url_request_context_getter.cc (right): https://codereview.chromium.org/1781193004/diff/60001/headless/lib/browser/headless_url_request_context_getter.cc#newcode89 headless/lib/browser/headless_url_request_context_getter.cc:89: return nullptr; Is it worth adding a comment to ...
4 years, 9 months ago (2016-03-14 18:16:08 UTC) #4
Sami
Thanks -- comments addressed. https://codereview.chromium.org/1781193004/diff/60001/headless/lib/browser/headless_url_request_context_getter.cc File headless/lib/browser/headless_url_request_context_getter.cc (right): https://codereview.chromium.org/1781193004/diff/60001/headless/lib/browser/headless_url_request_context_getter.cc#newcode89 headless/lib/browser/headless_url_request_context_getter.cc:89: return nullptr; On 2016/03/14 18:16:08, ...
4 years, 9 months ago (2016-03-14 18:33:27 UTC) #5
alex clarke (OOO till 29th)
lgtm
4 years, 9 months ago (2016-03-14 20:12:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781193004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781193004/80001
4 years, 9 months ago (2016-03-15 10:40:10 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-15 11:38:55 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 11:40:02 UTC) #12
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/f52fa5b3d50f38c0491adc757b05510a2df5ab93
Cr-Commit-Position: refs/heads/master@{#381208}

Powered by Google App Engine
This is Rietveld 408576698