Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: headless/test/headless_test_launcher.cc

Issue 1781193004: headless: Make it possible to configure an HTTP proxy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/test/headless_browser_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/test/headless_test_launcher.cc
diff --git a/headless/test/headless_test_launcher.cc b/headless/test/headless_test_launcher.cc
index e08e297e5f1c3014a0608acdd41211d930cabd92..c8ab7163be2d40e188fe653e7509ec78fb1e6905 100644
--- a/headless/test/headless_test_launcher.cc
+++ b/headless/test/headless_test_launcher.cc
@@ -45,8 +45,8 @@ class HeadlessTestLauncherDelegate : public content::TestLauncherDelegate {
protected:
content::ContentMainDelegate* CreateContentMainDelegate() override {
- // TODO(skyostil): Add a way to test custom options.
- HeadlessBrowser::Options::Builder options_builder(0, nullptr);
+ // Use HeadlessBrowserTest::SetBrowserOptions to override these defaults.
+ HeadlessBrowser::Options::Builder options_builder;
scoped_ptr<HeadlessBrowserImpl> browser(
new HeadlessBrowserImplForTest(options_builder.Build()));
return new HeadlessContentMainDelegate(std::move(browser));
« no previous file with comments | « headless/test/headless_browser_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698