Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 1780933003: Use std::unique_ptr. (Closed)

Created:
4 years, 9 months ago by mtklein_C
Modified:
4 years, 9 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : that simple? #

Patch Set 3 : maybe not #

Patch Set 4 : another #

Patch Set 5 : another #

Patch Set 6 : another #

Patch Set 7 : more #

Patch Set 8 : SkHackyAutoTDelete #

Patch Set 9 : explicit operator bool() to SkAutoTUnref #

Patch Set 10 : one more SkToBool #

Patch Set 11 : once more, all together #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -527 lines) Patch
M gyp/core.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkRefCnt.h View 1 2 3 4 5 6 7 8 2 chunks +8 lines, -3 lines 0 comments Download
M include/gpu/gl/SkGLContext.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/private/SkOncePtr.h View 3 chunks +3 lines, -3 lines 0 comments Download
M include/private/SkTemplates.h View 1 2 3 4 5 6 7 8 9 10 4 chunks +12 lines, -9 lines 0 comments Download
D include/private/SkUniquePtr.h View 1 chunk +0 lines, -408 lines 0 comments Download
M src/core/SkAdvancedTypefaceMetrics.h View 1 2 3 4 5 6 7 9 10 3 chunks +32 lines, -3 lines 0 comments Download
M src/core/SkAdvancedTypefaceMetrics.cpp View 1 2 3 4 5 6 7 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkGlyphCache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkSharedMutex.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrLayerAtlas.cpp View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/CPlusPlusEleven.cpp View 1 chunk +0 lines, -69 lines 0 comments Download
M tests/ClearTest.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageTest.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PictureTest.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M tests/ResourceCacheTest.cpp View 1 2 3 4 5 6 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 54 (31 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780933003/1
4 years, 9 months ago (2016-03-10 15:08:26 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/7016) Build-Win-MSVC-x86_64-Debug-Trybot on ...
4 years, 9 months ago (2016-03-10 15:16:35 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780933003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780933003/120001
4 years, 9 months ago (2016-03-10 16:30:36 UTC) #7
mtklein_C
Let's try this again, and if needed, fix up SkAdvancedTypefaceMetrics live?
4 years, 9 months ago (2016-03-10 16:42:54 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-10 16:45:01 UTC) #11
bungeman-skia
lgtm
4 years, 9 months ago (2016-03-10 17:48:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780933003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780933003/120001
4 years, 9 months ago (2016-03-10 17:48:28 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/7576)
4 years, 9 months ago (2016-03-10 17:50:19 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780933003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780933003/120001
4 years, 9 months ago (2016-03-10 18:08:45 UTC) #20
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://skia.googlesource.com/skia/+/20c1e3abfc681771f73eb19fde7284196e028940
4 years, 9 months ago (2016-03-10 18:10:09 UTC) #22
mtklein
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/1782973002/ by mtklein@google.com. ...
4 years, 9 months ago (2016-03-10 19:31:16 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780933003/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780933003/130001
4 years, 9 months ago (2016-03-10 20:02:53 UTC) #27
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-10 20:19:24 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780933003/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780933003/130001
4 years, 9 months ago (2016-03-11 13:17:50 UTC) #32
commit-bot: I haz the power
Committed patchset #8 (id:130001) as https://skia.googlesource.com/skia/+/3dd9ed37c24611af86f0fe374bd3698b63f09450
4 years, 9 months ago (2016-03-11 13:18:51 UTC) #34
mtklein
A revert of this CL (patchset #8 id:130001) has been created in https://codereview.chromium.org/1785353002/ by mtklein@google.com. ...
4 years, 9 months ago (2016-03-11 14:10:17 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780933003/150001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780933003/150001
4 years, 9 months ago (2016-03-16 15:03:43 UTC) #40
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/7148)
4 years, 9 months ago (2016-03-16 15:08:52 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780933003/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780933003/170001
4 years, 9 months ago (2016-03-16 15:25:21 UTC) #45
commit-bot: I haz the power
Committed patchset #10 (id:170001) as https://skia.googlesource.com/skia/+/2691d76a06e1af6282f8b3a3140cc93361be10c4
4 years, 9 months ago (2016-03-16 15:39:46 UTC) #47
mtklein
A revert of this CL (patchset #10 id:170001) has been created in https://codereview.chromium.org/1809693002/ by mtklein@google.com. ...
4 years, 9 months ago (2016-03-16 17:02:56 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780933003/190001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780933003/190001
4 years, 9 months ago (2016-03-16 17:08:51 UTC) #52
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 17:28:39 UTC) #54
Message was sent while issue was closed.
Committed patchset #11 (id:190001) as
https://skia.googlesource.com/skia/+/5f939ab658a228dce34a3b14a545638407150b92

Powered by Google App Engine
This is Rietveld 408576698