Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1780803002: Timeline: show RAIL phase strip unconditionally on actual records being present (Closed)

Created:
4 years, 9 months ago by caseq
Modified:
4 years, 9 months ago
Reviewers:
paulirish, alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Timeline: show RAIL phase strip unconditionally on actual records being present This shows RAIL strip on top of Timeline even in case there are no actual records present (but still conditional on RAIL experiment). Committed: https://crrev.com/82df1afea37d14685cc18ea1ab651b6859afd2e4 Cr-Commit-Position: refs/heads/master@{#380447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
caseq
4 years, 9 months ago (2016-03-09 23:49:19 UTC) #2
alph
lgtm
4 years, 9 months ago (2016-03-10 17:30:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780803002/1
4 years, 9 months ago (2016-03-10 17:30:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 19:33:29 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 19:35:15 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/82df1afea37d14685cc18ea1ab651b6859afd2e4
Cr-Commit-Position: refs/heads/master@{#380447}

Powered by Google App Engine
This is Rietveld 408576698