third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js - Issue 1780803002: Timeline: show RAIL phase strip unconditionally on actual records being present

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 1780803002: Timeline: show RAIL phase strip unconditionally on actual records being present (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

index 13ee21cf4f8b276f2ee832c30d3abc8335dc395b..7efe531dfd6eceecf405da9d1fa40e52e70a698a 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

@@ -559,10 +559,7 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {

{

if (!this._irModel)

return;

- var segments = this._irModel.interactionRecords();

- if (!segments || !segments.length)

- return;

- segments.forEach(this._appendSegment, this);

+ this._irModel.interactionRecords().forEach(this._appendSegment, this);

this._entryTypeByLevel[this._currentLevel++] = WebInspector.TimelineFlameChartEntryType.InteractionRecord;

« no previous file with comments | « no previous file | no next file » | no next file with comments »