Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 1780773003: Re-fix build errors from upgrading to clang 3.9 . (Closed)

Created:
4 years, 9 months ago by Jim Stichnoth
Modified:
4 years, 9 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-fix build errors from upgrading to clang 3.9 . This reverts commit 5526c1718b43d77d90850ec0409a21ecfc975b2c (https://codereview.chromium.org/1778663003) and implements it per jpp's suggestion. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c10c15696dc09b9d8c081f6372d19faaa8ecff2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M src/IceTargetLoweringX86Base.h View 2 chunks +3 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 9 months ago (2016-03-10 13:44:42 UTC) #3
John
lgtm thanks!
4 years, 9 months ago (2016-03-10 15:41:49 UTC) #4
Jim Stichnoth
4 years, 9 months ago (2016-03-10 16:19:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c10c15696dc09b9d8c081f6372d19faaa8ecff2b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698