Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1778663003: Subzero: Fix build errors from upgrading to clang 3.9 . (Closed)

Created:
4 years, 9 months ago by Jim Stichnoth
Modified:
4 years, 9 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M Makefile.standalone View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceTargetLoweringX86Base.h View 2 chunks +13 lines, -3 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 9 months ago (2016-03-09 06:46:09 UTC) #3
Jim Stichnoth
Committed patchset #1 (id:1) manually as 5526c1718b43d77d90850ec0409a21ecfc975b2c (presubmit successful).
4 years, 9 months ago (2016-03-09 06:46:23 UTC) #5
John
4 years, 9 months ago (2016-03-09 16:33:29 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1778663003/diff/1/src/IceTargetLoweringX86Base.h
File src/IceTargetLoweringX86Base.h (right):

https://codereview.chromium.org/1778663003/diff/1/src/IceTargetLoweringX86Bas...
src/IceTargetLoweringX86Base.h:82: static TargetX86Base *create(Cfg *Func) {
return new TargetX86Base(Func); }
instead of adding those three methods, create should've been deleted?...

Powered by Google App Engine
This is Rietveld 408576698