Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1780663002: [heap] Remove dead code in map space class. (Closed)

Created:
4 years, 9 months ago by Hannes Payer (out of office)
Modified:
4 years, 9 months ago
Reviewers:
ulan, Marcel Hlopko
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove dead code in map space class. BUG= Committed: https://crrev.com/6975f77b4dc6bfd8c85bdb40af56b19793ce473d Cr-Commit-Position: refs/heads/master@{#34619}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -20 lines) Patch
M src/heap/spaces.h View 3 chunks +1 line, -20 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Hannes Payer (out of office)
4 years, 9 months ago (2016-03-09 12:26:58 UTC) #3
ulan
lgtm
4 years, 9 months ago (2016-03-09 12:30:07 UTC) #4
Marcel Hlopko
lgtm, always nice to clean up the code :)
4 years, 9 months ago (2016-03-09 12:44:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780663002/1
4 years, 9 months ago (2016-03-09 12:54:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 12:56:00 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 12:57:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6975f77b4dc6bfd8c85bdb40af56b19793ce473d
Cr-Commit-Position: refs/heads/master@{#34619}

Powered by Google App Engine
This is Rietveld 408576698