Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: src/heap/spaces.h

Issue 1780663002: [heap] Remove dead code in map space class. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/spaces.h
diff --git a/src/heap/spaces.h b/src/heap/spaces.h
index b940a21f4ecf4c1e23c8ff3f395086bda8d7a248..7c4ff9663ab0a06f290ca78c8f315384f754737a 100644
--- a/src/heap/spaces.h
+++ b/src/heap/spaces.h
@@ -106,10 +106,6 @@ class Space;
#define DCHECK_PAGE_OFFSET(offset) \
DCHECK((Page::kObjectStartOffset <= offset) && (offset <= Page::kPageSize))
-#define DCHECK_MAP_PAGE_INDEX(index) \
- DCHECK((0 <= index) && (index <= MapSpace::kMaxMapPageIndex))
-
-
class MarkBit {
public:
typedef uint32_t CellType;
@@ -2865,12 +2861,7 @@ class MapSpace : public PagedSpace {
public:
// Creates a map space object.
MapSpace(Heap* heap, AllocationSpace id)
- : PagedSpace(heap, id, NOT_EXECUTABLE),
- max_map_space_pages_(kMaxMapPageIndex - 1) {}
-
- // Given an index, returns the page address.
- // TODO(1600): this limit is artifical just to keep code compilable
- static const int kMaxMapPageIndex = 1 << 16;
+ : PagedSpace(heap, id, NOT_EXECUTABLE) {}
int RoundSizeDownToObjectAlignment(int size) override {
if (base::bits::IsPowerOfTwo32(Map::kSize)) {
@@ -2883,16 +2874,6 @@ class MapSpace : public PagedSpace {
#ifdef VERIFY_HEAP
void VerifyObject(HeapObject* obj) override;
#endif
-
- private:
- static const int kMapsPerPage = Page::kAllocatableMemory / Map::kSize;
-
- // Do map space compaction if there is a page gap.
- int CompactionThreshold() {
- return kMapsPerPage * (max_map_space_pages_ - 1);
- }
-
- const int max_map_space_pages_;
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698