Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1780593002: V8 Bindings: Don't attempt to set an empty V8HiddenValue (Closed)

Created:
4 years, 9 months ago by jsbell
Modified:
4 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, jsbell+idb_chromium.org, blink-reviews-bindings_chromium.org, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

V8 Bindings: Don't attempt to set an empty V8HiddenValue After an execution context is stopped, IndexedDB returns an empty ScriptValue() on property access. The bindings code should not attempt to cache this using V8HiddenValue. BUG=590730 R=haraken@chromium.org Committed: https://crrev.com/96ad5a7ab9cea6a586e5df4acef371ef35d6c5ba Cr-Commit-Position: refs/heads/master@{#380067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/storage/indexeddb/empty-crash.html View 1 chunk +45 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jsbell
haraken@ - please take a look? I don't know if the bots will like this ...
4 years, 9 months ago (2016-03-09 00:44:43 UTC) #1
haraken
LGTM
4 years, 9 months ago (2016-03-09 01:00:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780593002/1
4 years, 9 months ago (2016-03-09 03:58:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 04:42:24 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 04:44:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96ad5a7ab9cea6a586e5df4acef371ef35d6c5ba
Cr-Commit-Position: refs/heads/master@{#380067}

Powered by Google App Engine
This is Rietveld 408576698