Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp

Issue 1780593002: V8 Bindings: Don't attempt to set an empty V8HiddenValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/storage/indexeddb/empty-crash.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp b/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp
index 58af4258d304900a1d23d7e9b480f92402d724b7..bd1191daa7653c12e7d1123f4e144d460500f013 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp
@@ -37,6 +37,8 @@ v8::Local<v8::Value> V8HiddenValue::getHiddenValue(ScriptState* scriptState, v8:
bool V8HiddenValue::setHiddenValue(ScriptState* scriptState, v8::Local<v8::Object> object, v8::Local<v8::String> key, v8::Local<v8::Value> value)
{
+ if (UNLIKELY(value.IsEmpty()))
+ return false;
return v8CallBoolean(object->SetPrivate(scriptState->context(), v8::Private::ForApi(scriptState->isolate(), key), value));
}
« no previous file with comments | « third_party/WebKit/LayoutTests/storage/indexeddb/empty-crash.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698