Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 1780473003: Remove most clang-cl special cases from cpu_id.cc (Closed)

Created:
3 years, 2 months ago by Nico
Modified:
3 years, 2 months ago
Reviewers:
fbarchard, fbarchard1
Base URL:
https://chromium.googlesource.com/libyuv/libyuv.git@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Remove most clang-cl special cases from cpu_id.cc They are not needed, and due to them there was a call to _xgetbv() without a declaration of the function. This used to work because we implicitly included intrin.h in all translation units with clang-cl, but we want to stop doing that. BUG=chromium:592745 R=fbarchard@google.com Committed: https://chromium.googlesource.com/libyuv/libyuv/+/76aee8ced7ca74c724d69c1dcf9891348450c8e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M source/cpu_id.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Nico
If this is ok, please land it for me too.
3 years, 2 months ago (2016-03-08 20:56:03 UTC) #2
fbarchard1
lgtm
3 years, 2 months ago (2016-03-10 18:23:48 UTC) #4
fbarchard1
3 years, 2 months ago (2016-03-10 22:01:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
76aee8ced7ca74c724d69c1dcf9891348450c8e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698