Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 178046: Linux gcc4.4 fix: stop crashing when loading flash. (Closed)

Created:
11 years, 3 months ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, piman
CC:
chromium-reviews_googlegroups.com, fta, Craig
Visibility:
Public.

Description

Linux gcc4.4 fix: stop crashing when loading flash. sizeof(bool) is 1 byte in opt mode. We pass a pointer to a bool to a function expecting a void*. It writes 4 bytes of data to the pointer, rather than 1 byte. This corrupts the stack bordering the bool stack variable, thereby manifesting itself as a crash. In particular, we were overwriting a spilled register (which stored an object pointer) with 3 bytes worth of zeros. After returning from the function, we called into the object, which now had the wrong pointer. BUG=http://crbug.com/20045 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25003

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M webkit/glue/plugins/webplugin_delegate_impl_gtk.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
willchan no longer on Chromium
11 years, 3 months ago (2009-09-01 00:55:09 UTC) #1
Evan Martin
You win the gangster of the year award. LGTM
11 years, 3 months ago (2009-09-01 00:58:40 UTC) #2
piman
11 years, 3 months ago (2009-09-01 01:01:05 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698