Linux gcc4.4 fix: stop crashing when loading flash.

webkit/glue/plugins/webplugin_delegate_impl_gtk.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/plugins/webplugin_delegate_impl.h"
 
 #include <string>
 #include <vector>
 
 #include <gtk/gtk.h>
@@ skipping 21 matching lines @@
 #include "third_party/npapi/bindings/npapi_x11.h"
 
 using WebKit::WebCursorInfo;
 using WebKit::WebKeyboardEvent;
 using WebKit::WebInputEvent;
 using WebKit::WebMouseEvent;
 
 WebPluginDelegateImpl::WebPluginDelegateImpl(
     gfx::PluginWindowHandle containing_view,
     NPAPI::PluginInstance *instance)
-    :
-      windowed_handle_(0),
+    : windowed_handle_(0),
       windowed_did_set_window_(false),
       windowless_(false),
       plugin_(NULL),
       windowless_needs_set_window_(true),
       instance_(instance),
       pixmap_(NULL),
       first_event_time_(-1.0),
       plug_(NULL),
       socket_(NULL),
       parent_(containing_view),
@@ skipping 57 matching lines @@
 }
 
 void WebPluginDelegateImpl::InstallMissingPlugin() {
   NOTIMPLEMENTED();
 }
 
 bool WebPluginDelegateImpl::WindowedCreatePlugin() {
   DCHECK(!windowed_handle_);
   DCHECK(!plug_);
 
-  bool xembed;
+  // NPP_GetValue() will write 4 bytes of data to this variable.  Don't use a
+  // single byte bool, use an int instead.
+  int xembed;
   NPError err = instance_->NPP_GetValue(NPPVpluginNeedsXEmbed, &xembed);
   DCHECK(err == NPERR_NO_ERROR);
   if (!xembed) {
     NOTIMPLEMENTED() << "Windowed plugin but without xembed.";
     return false;
   }
 
   // Passing 0 as the socket XID creates a plug without plugging it in a socket
   // yet, so that it can be latter added with gtk_socket_add_id().
   plug_ = gtk_plug_new(0);
@@ skipping 569 matching lines @@
   if (event->event == WM_MOUSEMOVE) {
     // Snag a reference to the current cursor ASAP in case the plugin modified
     // it. There is a nasty race condition here with the multiprocess browser
     // as someone might be setting the cursor in the main process as well.
     *cursor = current_windowless_cursor_;
   }
 #endif
 
   return ret;
 }