[PerfTry] Make it possible to ./run_benchmark try within tools/perf

[PerfTry] Make it possible to ./run_benchmark try within tools/perf

This CL makes two changes to trybot_command to make it possible to run perf
try jobs without cd'ing to src/.

1. It uses tools/perf's core.path_util.GetChromiumSrcDir() to locate the bisect
   config file in Chromium

2. It removes the Blink change detection functionality which is no longer
   needed given the Chromium merger with Blink, but depended on a hardcoded
   path.

BUG=593075
R=dpranke,aiolos,nednguyen,prasadv

[eakuefner, 2016-03-08 18:42:07]

eakuefner@chromium.org changed reviewers:
+ dpranke@chromium.org
- dpranke@google.com

[eakuefner, 2016-03-08 18:42:07]

+dpranke for third_party/WebKit/Tools OWNERS

Successfully submitted tryjob with this change here:
https://codereview.chromium.org/1776713002

[eakuefner, 2016-03-08 18:42:13]

The CQ bit was checked by eakuefner@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-08 18:42:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780453002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780453002/1

[commit-bot: I haz the power, 2016-03-08 20:03:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 20:03:47]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nednguyen, 2016-03-08 20:39:52]

lgtm

Sorry if't hard to update the tests  :-(

https://codereview.chromium.org/1780453002/diff/1/tools/perf/core/trybot_comm...
File tools/perf/core/trybot_command.py (right):

https://codereview.chromium.org/1780453002/diff/1/tools/perf/core/trybot_comm...
tools/perf/core/trybot_command.py:18: CHROMIUM_CONFIG_FILENAME =
os.path.join(path_util.GetChromiumSrcDir(), 'tools',
Can you rename this to CHROMIUM_TRYBOT_CONFIG_PATH

[eakuefner, 2016-03-08 22:25:01]

eakuefner@chromium.org changed reviewers:
+ qyearsley@chromium.org

[eakuefner, 2016-03-08 22:25:01]

+qyearsley

[qyearsley, 2016-03-08 22:52:42]

lgtm

[Dirk Pranke, 2016-03-08 22:58:41]

I know nothing about these files. The changes look syntactically correct to me,
but I defer to the others for the actual review :).

[eakuefner, 2016-03-09 18:16:03]

On 2016/03/08 at 22:58:41, dpranke wrote:
> I know nothing about these files. The changes look syntactically correct to
me, but I defer to the others for the actual review :).

Dirk, I just need a stamp for the two files I'm removing in
third_party/WebKit/Tools, for which you're an owner (and which bisect team
probably would have had per-file owners on if those files weren't so old).

[eakuefner, 2016-03-09 18:17:26]

On 2016/03/09 at 18:16:03, eakuefner wrote:
> On 2016/03/08 at 22:58:41, dpranke wrote:
> > I know nothing about these files. The changes look syntactically correct to
me, but I defer to the others for the actual review :).
> 
> Dirk, I just need a stamp for the two files I'm removing in
third_party/WebKit/Tools, for which you're an owner (and which bisect team
probably would have had per-file owners on if those files weren't so old).

Actually, on second thought I'll punt removing those files from this CL.

[Dirk Pranke, 2016-03-09 18:32:14]

lgtm either way :)

[eakuefner, 2016-03-21 17:05:41]

The CQ bit was checked by eakuefner@chromium.org

[eakuefner, 2016-03-21 17:05:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, qyearsley@chromium.org, nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/1780453002/#ps20001
(title: "remove webkit changes")

[commit-bot: I haz the power, 2016-03-21 17:06:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780453002/20001

[commit-bot: I haz the power, 2016-03-21 18:01:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 18:01:13]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[aiolos (Not reviewing), 2016-03-24 00:28:41]

It looks like you need to fix some trybot unittests.

[qyearsley, 2016-07-31 20:14:17]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-31 20:14:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-31 21:00:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-31 21:00:42]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[qyearsley, 2016-08-23 21:34:10]

On 2016/03/24 at 00:28:41, aiolos wrote:
> It looks like you need to fix some trybot unittests.

Hi Ethan, did you still want to make this change? It seemed like a good change.

[eakuefner, 2016-08-23 21:36:22]

Yes, I'm going to dry run this right now to give myself a fresh record of which
tests need fixing.

[eakuefner, 2016-08-23 21:36:28]

The CQ bit was checked by eakuefner@chromium.org to run a CQ dry run

[prasadv1, 2016-08-23 21:37:24]

On 2016/08/23 21:34:10, qyearsley wrote:
> On 2016/03/24 at 00:28:41, aiolos wrote:
> > It looks like you need to fix some trybot unittests.
> 
> Hi Ethan, did you still want to make this change? It seemed like a good
change.

I'm working on refactoring Perf Trybot and removing the config file dependency.

[commit-bot: I haz the power, 2016-08-23 21:37:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eakuefner, 2016-08-23 21:38:49]

On 2016/08/23 at 21:37:24, prasadv wrote:
> On 2016/08/23 21:34:10, qyearsley wrote:
> > On 2016/03/24 at 00:28:41, aiolos wrote:
> > > It looks like you need to fix some trybot unittests.
> > 
> > Hi Ethan, did you still want to make this change? It seemed like a good
change.
> 
> I'm working on refactoring Perf Trybot and removing the config file
dependency.

Do you think this is okay to land, or should we just wait for your refactor?

[prasadv1, 2016-08-23 21:42:19]

On 2016/08/23 21:38:49, eakuefner wrote:
> On 2016/08/23 at 21:37:24, prasadv wrote:
> > On 2016/08/23 21:34:10, qyearsley wrote:
> > > On 2016/03/24 at 00:28:41, aiolos wrote:
> > > > It looks like you need to fix some trybot unittests.
> > > 
> > > Hi Ethan, did you still want to make this change? It seemed like a good
> change.
> > 
> > I'm working on refactoring Perf Trybot and removing the config file
> dependency.
> 
> Do you think this is okay to land, or should we just wait for your refactor?

I think this change might not be required.

[nednguyen, 2016-08-23 21:43:34]

On 2016/08/23 21:38:49, eakuefner wrote:
> On 2016/08/23 at 21:37:24, prasadv wrote:
> > On 2016/08/23 21:34:10, qyearsley wrote:
> > > On 2016/03/24 at 00:28:41, aiolos wrote:
> > > > It looks like you need to fix some trybot unittests.
> > > 
> > > Hi Ethan, did you still want to make this change? It seemed like a good
> change.
> > 
> > I'm working on refactoring Perf Trybot and removing the config file
> dependency.
> 
> Do you think this is okay to land, or should we just wait for your refactor?

After Prasad's refactor, I think we may no longer need this fix

[eakuefner, 2016-08-23 21:47:06]

The CQ bit was unchecked by eakuefner@chromium.org

[eakuefner, 2016-08-23 21:47:17]

Okay, closed.