Issue 1776713002: CL for perf tryjob on android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1776713002: CL for perf tryjob on android (Closed)

Created:
4 years, 9 months ago by eakuefner

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, blink-reviews, darin-cc_chromium.org, telemetry-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, auto-bisect-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

CL for perf tryjob on android

Patch Set 1 #

Total comments: 1

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -163 lines)			Patch
M	content/renderer/menu_item_builder.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	third_party/WebKit/Tools/run-perf-test.cfg	View	1 chunk	+0 lines, -78 lines	0 comments	Download
M	tools/perf/core/trybot_command.py	View	4 chunks	+5 lines, -9 lines	0 comments	Download
M	tools/run-perf-test.cfg	View	1 chunk	+6 lines, -76 lines	1 comment	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

aiolos (Not reviewing)

https://codereview.chromium.org/1776713002/diff/1/tools/run-perf-test.cfg File tools/run-perf-test.cfg (left): https://codereview.chromium.org/1776713002/diff/1/tools/run-perf-test.cfg#oldcode12 tools/run-perf-test.cfg:12: Changes to this file should never be submitted. Did ...

4 years, 9 months ago (2016-03-08 18:48:42 UTC) #2

eakuefner

4 years, 9 months ago (2016-03-08 18:51:20 UTC) #3

On 2016/03/08 at 18:48:42, aiolos wrote:
> https://codereview.chromium.org/1776713002/diff/1/tools/run-perf-test.cfg
> File tools/run-perf-test.cfg (left):
> 
>
https://codereview.chromium.org/1776713002/diff/1/tools/run-perf-test.cfg#old...
> tools/run-perf-test.cfg:12: Changes to this file should never be submitted.
> Did you mean to include this file in your cl?

Yes. This is a tryjob and those changes are made automatically by the tool.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages