Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1780443002: Cleanup: roll AutofillCCInfoBarDelegate into AutofillSaveCardInfoBarDelegateMobile. (Closed)

Created:
4 years, 9 months ago by Justin Donnelly
Modified:
4 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pay_mac_bubble_default
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: roll AutofillCCInfoBarDelegate into AutofillSaveCardInfoBarDelegateMobile. The former is no longer used on desktop and therefore no longer needs to be maintained as a separate class. Depends on https://codereview.chromium.org/1761073005/ which removes the last reference. BUG= Committed: https://crrev.com/564a23ef69b81c62a54d1b86b843ec5f49c037a9 Cr-Commit-Position: refs/heads/master@{#380650}

Patch Set 1 : #

Total comments: 12

Patch Set 2 : Respond to comments #

Total comments: 2

Patch Set 3 : Make overriden methods public. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -422 lines) Patch
D chrome/browser/autofill/autofill_cc_infobar_delegate_unittest.cc View 1 chunk +0 lines, -148 lines 0 comments Download
A + chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc View 5 chunks +22 lines, -19 lines 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D components/autofill/core/browser/autofill_cc_infobar_delegate.h View 1 chunk +0 lines, -82 lines 0 comments Download
D components/autofill/core/browser/autofill_cc_infobar_delegate.cc View 1 chunk +0 lines, -130 lines 0 comments Download
M components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h View 1 2 3 chunks +29 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc View 1 2 2 chunks +83 lines, -4 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D ui/gfx/vector_icons/autofill.icon View 1 1 chunk +0 lines, -29 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (13 generated)
Justin Donnelly
4 years, 9 months ago (2016-03-08 19:21:46 UTC) #5
Evan Stade
https://codereview.chromium.org/1780443002/diff/60001/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://codereview.chromium.org/1780443002/diff/60001/chrome/chrome_tests_unit.gypi#newcode330 chrome/chrome_tests_unit.gypi:330: 'browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc', is this used by ios? if not, maybe ...
4 years, 9 months ago (2016-03-08 21:41:49 UTC) #6
Justin Donnelly
https://codereview.chromium.org/1780443002/diff/60001/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://codereview.chromium.org/1780443002/diff/60001/chrome/chrome_tests_unit.gypi#newcode330 chrome/chrome_tests_unit.gypi:330: 'browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc', On 2016/03/08 21:41:49, Evan Stade wrote: > is ...
4 years, 9 months ago (2016-03-08 22:41:47 UTC) #7
Evan Stade
lgtm https://codereview.chromium.org/1780443002/diff/60001/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h File components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h (right): https://codereview.chromium.org/1780443002/diff/60001/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h#newcode45 components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h:45: int GetIconId() const override; On 2016/03/08 22:41:47, Justin ...
4 years, 9 months ago (2016-03-08 22:52:42 UTC) #8
Justin Donnelly
https://codereview.chromium.org/1780443002/diff/60001/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h File components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h (right): https://codereview.chromium.org/1780443002/diff/60001/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h#newcode45 components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h:45: int GetIconId() const override; On 2016/03/08 22:52:42, Evan Stade ...
4 years, 9 months ago (2016-03-09 03:46:07 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 1761073005 Patch 1). Please resolve the dependency and ...
4 years, 9 months ago (2016-03-09 03:47:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780443002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780443002/100001
4 years, 9 months ago (2016-03-10 19:11:57 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/128872)
4 years, 9 months ago (2016-03-10 20:53:57 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780443002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780443002/100001
4 years, 9 months ago (2016-03-11 15:06:38 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years, 9 months ago (2016-03-11 16:38:56 UTC) #22
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 16:40:14 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/564a23ef69b81c62a54d1b86b843ec5f49c037a9
Cr-Commit-Position: refs/heads/master@{#380650}

Powered by Google App Engine
This is Rietveld 408576698