Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1761073005: Enable the save card bubble on Mac without a flag. (Closed)

Created:
4 years, 9 months ago by Justin Donnelly
Modified:
4 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable the save card bubble on Mac without a flag. BUG=566271 Committed: https://crrev.com/f41a2211a775b1f607eabe0c8e934daa42c15be0 Cr-Commit-Position: refs/heads/master@{#380073}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -37 lines) Patch
M chrome/browser/ui/autofill/chrome_autofill_client.cc View 2 chunks +6 lines, -27 lines 2 comments Download
M components/autofill/core/common/autofill_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M components/autofill/core/common/autofill_switches.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (3 generated)
Justin Donnelly
4 years, 9 months ago (2016-03-04 20:39:58 UTC) #2
Justin Donnelly
Friendly ping.
4 years, 9 months ago (2016-03-07 21:23:00 UTC) #3
Evan Stade
https://codereview.chromium.org/1761073005/diff/1/chrome/browser/ui/autofill/chrome_autofill_client.cc File chrome/browser/ui/autofill/chrome_autofill_client.cc (left): https://codereview.chromium.org/1761073005/diff/1/chrome/browser/ui/autofill/chrome_autofill_client.cc#oldcode210 chrome/browser/ui/autofill/chrome_autofill_client.cc:210: AutofillCCInfoBarDelegate::CreateForLocalSave( do you still need this fn for something? ...
4 years, 9 months ago (2016-03-07 22:42:03 UTC) #4
Justin Donnelly
https://codereview.chromium.org/1761073005/diff/1/chrome/browser/ui/autofill/chrome_autofill_client.cc File chrome/browser/ui/autofill/chrome_autofill_client.cc (left): https://codereview.chromium.org/1761073005/diff/1/chrome/browser/ui/autofill/chrome_autofill_client.cc#oldcode210 chrome/browser/ui/autofill/chrome_autofill_client.cc:210: AutofillCCInfoBarDelegate::CreateForLocalSave( On 2016/03/07 22:42:03, Evan Stade wrote: > do ...
4 years, 9 months ago (2016-03-07 23:14:41 UTC) #5
Evan Stade
On 2016/03/07 23:14:41, Justin Donnelly wrote: > https://codereview.chromium.org/1761073005/diff/1/chrome/browser/ui/autofill/chrome_autofill_client.cc > File chrome/browser/ui/autofill/chrome_autofill_client.cc (left): > > https://codereview.chromium.org/1761073005/diff/1/chrome/browser/ui/autofill/chrome_autofill_client.cc#oldcode210 ...
4 years, 9 months ago (2016-03-08 00:56:39 UTC) #6
Justin Donnelly
On 2016/03/08 00:56:39, Evan Stade wrote: > I'm not sure how the cleanup part would ...
4 years, 9 months ago (2016-03-08 19:21:30 UTC) #7
Evan Stade
On 2016/03/08 19:21:30, Justin Donnelly wrote: > On 2016/03/08 00:56:39, Evan Stade wrote: > > ...
4 years, 9 months ago (2016-03-08 21:43:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761073005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761073005/1
4 years, 9 months ago (2016-03-09 03:53:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 05:13:11 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 05:15:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f41a2211a775b1f607eabe0c8e934daa42c15be0
Cr-Commit-Position: refs/heads/master@{#380073}

Powered by Google App Engine
This is Rietveld 408576698