Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 178043008: [Reland] Introduce telemetry.web_components and a simple component-based Results object (Closed)

Created:
6 years, 10 months ago by nduca
Modified:
6 years, 9 months ago
Reviewers:
achuith, achuithb
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Reland] Introduce telemetry.web_components and a simple component-based Results object The main result of this patch is that cd $TELEMETRY && python -m telemetry.web_components.results_viewer will produce an HTML file that has the same standalone-and-emailable properties as telemetry's existing HTML results object, but that is built out of tvcm components, trace-viewer's component model. Followup patches will expand out results_viewer.js with features to actually be a viable replacement for Telemetry's existing results.html. Importantly, with this checkin, telemetry's existing ./run_tests will also run any javascript unittests and the presubmit will lint the same js and css files. BUG=340096 TBR=tonyg,achuith Original review at: https://codereview.chromium.org/169283004/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -0 lines) Patch
M tools/telemetry/PRESUBMIT.py View 1 chunk +6 lines, -0 lines 0 comments Download
A tools/telemetry/run_web_components_dev_server View 1 chunk +23 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/web_components/__init__.py View 1 chunk +12 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/web_components/dev_server.py View 1 chunk +23 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/web_components/results_viewer.js View 1 chunk +39 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/web_components/results_viewer.py View 1 chunk +30 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/web_components/results_viewer_unittest.js View 1 chunk +16 lines, -0 lines 0 comments Download
A + tools/telemetry/telemetry/web_components/tvcm_stub.py View 1 chunk +7 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/web_components/viewer.py View 1 chunk +63 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/web_components/viewer_bootstrap.js View 1 chunk +18 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/web_components/viewer_unittest.py View 1 chunk +25 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/web_components/viewer_unittest_data.js View 1 chunk +34 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/web_components/web_components_project.py View 1 chunk +21 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/web_components/web_components_unittest.py View 1 chunk +15 lines, -0 lines 0 comments Download
M tools/telemetry_tools/bootstrap_deps View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nduca
ptal
6 years, 10 months ago (2014-02-27 00:22:21 UTC) #1
achuithb
On 2014/02/27 00:22:21, nduca wrote: > ptal lgtm, thanks!
6 years, 10 months ago (2014-02-27 00:23:14 UTC) #2
nduca
Committed patchset #1 manually as r253658 (presubmit successful).
6 years, 10 months ago (2014-02-27 00:26:54 UTC) #3
achuithb
On 2014/02/27 00:26:54, nduca wrote: > Committed patchset #1 manually as r253658 (presubmit successful). Fyi, ...
6 years, 9 months ago (2014-02-27 22:07:28 UTC) #4
achuithb
6 years, 9 months ago (2014-02-27 22:18:31 UTC) #5
Message was sent while issue was closed.
On 2014/02/27 22:07:28, achuith.bhandarkar wrote:
> On 2014/02/27 00:26:54, nduca wrote:
> > Committed patchset #1 manually as r253658 (presubmit successful).
> 
> Fyi, this always runs a tvcm unittest even when you provide a filter.
> 
> For instance, with:
> run_tests testBrowserCreation
> some tvcm test will first run (web_components_unittest.py's load_tests is
> called).

_DiscoverTestsInModuleImpl actually creates a browser instance and navigates to
it:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/trace-...

Powered by Google App Engine
This is Rietveld 408576698