Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: tools/telemetry/PRESUBMIT.py

Issue 178043008: [Reland] Introduce telemetry.web_components and a simple component-based Results object (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tools/telemetry/run_web_components_dev_server » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 import sys 5 import sys
6 6
7 PYLINT_BLACKLIST = [] 7 PYLINT_BLACKLIST = []
8 PYLINT_DISABLED_WARNINGS = ['R0923', 'R0201', 'E1101'] 8 PYLINT_DISABLED_WARNINGS = ['R0923', 'R0201', 'E1101']
9 9
10 def _CommonChecks(input_api, output_api): 10 def _CommonChecks(input_api, output_api):
11 results = [] 11 results = []
12 12
13 # TODO(nduca): This should call update_docs.IsUpdateDocsNeeded(). 13 # TODO(nduca): This should call update_docs.IsUpdateDocsNeeded().
14 # Disabled due to crbug.com/255326. 14 # Disabled due to crbug.com/255326.
15 if False: 15 if False:
16 update_docs_path = os.path.join( 16 update_docs_path = os.path.join(
17 input_api.PresubmitLocalPath(), 'update_docs') 17 input_api.PresubmitLocalPath(), 'update_docs')
18 assert os.path.exists(update_docs_path) 18 assert os.path.exists(update_docs_path)
19 results.append(output_api.PresubmitError( 19 results.append(output_api.PresubmitError(
20 'Docs are stale. Please run:\n' + 20 'Docs are stale. Please run:\n' +
21 '$ %s' % os.path.abspath(update_docs_path))) 21 '$ %s' % os.path.abspath(update_docs_path)))
22 22
23 # Importing telemetry.web_components actually brings tvcm into the path.
24 import telemetry.web_components # pylint: disable=W0612
25 from tvcm import presubmit_checker
26 checker = presubmit_checker.PresubmitChecker(input_api, output_api)
27 results += checker.RunChecks()
28
23 results.extend(input_api.canned_checks.RunPylint( 29 results.extend(input_api.canned_checks.RunPylint(
24 input_api, output_api, 30 input_api, output_api,
25 black_list=PYLINT_BLACKLIST, 31 black_list=PYLINT_BLACKLIST,
26 disabled_warnings=PYLINT_DISABLED_WARNINGS)) 32 disabled_warnings=PYLINT_DISABLED_WARNINGS))
27 return results 33 return results
28 34
29 def GetPathsToPrepend(input_api): 35 def GetPathsToPrepend(input_api):
30 return [input_api.PresubmitLocalPath()] 36 return [input_api.PresubmitLocalPath()]
31 37
32 def RunWithPrependedPath(prepended_path, fn, *args): 38 def RunWithPrependedPath(prepended_path, fn, *args):
(...skipping 11 matching lines...) Expand all
44 results.extend(_CommonChecks(input_api, output_api)) 50 results.extend(_CommonChecks(input_api, output_api))
45 return results 51 return results
46 return RunWithPrependedPath(GetPathsToPrepend(input_api), go) 52 return RunWithPrependedPath(GetPathsToPrepend(input_api), go)
47 53
48 def CheckChangeOnCommit(input_api, output_api): 54 def CheckChangeOnCommit(input_api, output_api):
49 def go(): 55 def go():
50 results = [] 56 results = []
51 results.extend(_CommonChecks(input_api, output_api)) 57 results.extend(_CommonChecks(input_api, output_api))
52 return results 58 return results
53 return RunWithPrependedPath(GetPathsToPrepend(input_api), go) 59 return RunWithPrependedPath(GetPathsToPrepend(input_api), go)
OLDNEW
« no previous file with comments | « no previous file | tools/telemetry/run_web_components_dev_server » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698