Issue 1780333002: Ignore bounds in compile time type tests, since they will have been checked at

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1780333002: Ignore bounds in compile time type tests, since they will have been checked at (Closed)

Created:
4 years, 9 months ago by regis

Modified:
4 years, 9 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Ignore bounds in compile time type tests, since they will have been checked at run time (fixes issue 25935). Add regression test. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/ea7929d2fb823210b2178b0eef4c8bf1b6aba45a

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -3 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+24 lines, -2 lines	0 comments	Download
A	tests/language/regress_25935_test.dart	View	1 chunk	+26 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

regis

4 years, 9 months ago (2016-03-10 22:22:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ea7929d2fb823210b2178b0eef4c8bf1b6aba45a (presubmit successful).