Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: runtime/vm/class_finalizer.cc

Issue 1780333002: Ignore bounds in compile time type tests, since they will have been checked at (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/class_finalizer.h" 5 #include "vm/class_finalizer.h"
6 6
7 #include "vm/code_generator.h" 7 #include "vm/code_generator.h"
8 #include "vm/flags.h" 8 #include "vm/flags.h"
9 #include "vm/heap.h" 9 #include "vm/heap.h"
10 #include "vm/isolate.h" 10 #include "vm/isolate.h"
(...skipping 1047 matching lines...) Expand 10 before | Expand all | Expand 10 after
1058 // No compile-time error during finalization. 1058 // No compile-time error during finalization.
1059 const String& type_name = String::Handle(Z, type.UserVisibleName()); 1059 const String& type_name = String::Handle(Z, type.UserVisibleName());
1060 FinalizeMalboundedType(bound_error, 1060 FinalizeMalboundedType(bound_error,
1061 Script::Handle(Z, cls.script()), 1061 Script::Handle(Z, cls.script()),
1062 type, 1062 type,
1063 "type '%s' has an out of bound type argument", 1063 "type '%s' has an out of bound type argument",
1064 type_name.ToCString()); 1064 type_name.ToCString());
1065 if (FLAG_trace_type_finalization) { 1065 if (FLAG_trace_type_finalization) {
1066 THR_Print("Marking type '%s' as malbounded: %s\n", 1066 THR_Print("Marking type '%s' as malbounded: %s\n",
1067 String::Handle(Z, type.Name()).ToCString(), 1067 String::Handle(Z, type.Name()).ToCString(),
1068 bound_error.ToCString()); 1068 bound_error.ToErrorCString());
1069 } 1069 }
1070 } 1070 }
1071 } 1071 }
1072 if (FLAG_trace_type_finalization) { 1072 if (FLAG_trace_type_finalization) {
1073 THR_Print("Done checking bounds of type '%s': %s\n", 1073 THR_Print("Done checking bounds of type '%s': %s\n",
1074 String::Handle(Z, type.Name()).ToCString(), 1074 String::Handle(Z, type.Name()).ToCString(),
1075 type.ToCString()); 1075 type.ToCString());
1076 } 1076 }
1077 } 1077 }
1078 1078
(...skipping 2242 matching lines...) Expand 10 before | Expand all | Expand 10 after
3321 ASSERT(fields_array.Length() == ByteBuffer::NumberOfFields()); 3321 ASSERT(fields_array.Length() == ByteBuffer::NumberOfFields());
3322 field ^= fields_array.At(0); 3322 field ^= fields_array.At(0);
3323 ASSERT(field.Offset() == ByteBuffer::data_offset()); 3323 ASSERT(field.Offset() == ByteBuffer::data_offset());
3324 name ^= field.name(); 3324 name ^= field.name();
3325 expected_name ^= String::New("_data"); 3325 expected_name ^= String::New("_data");
3326 ASSERT(String::EqualsIgnoringPrivateKey(name, expected_name)); 3326 ASSERT(String::EqualsIgnoringPrivateKey(name, expected_name));
3327 #endif 3327 #endif
3328 } 3328 }
3329 3329
3330 } // namespace dart 3330 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698