Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1780063003: Move ScopedSetInsertion to third_party/base/stl_util.h (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move ScopedSetInsertion to third_party/base/stl_util.h Also move ScopedFileStream, since it isn't specific to the parser, and belongs with the fxcrt object it manipulates. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/99406198ac4921a53425edc73cac67e7b4760895

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -21 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 1 chunk +0 lines, -19 lines 0 comments Download
M core/include/fxcrt/fx_ext.h View 1 chunk +6 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/cpdf_document.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdfsave.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/base/stl_util.h View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
ochang, for review.
4 years, 9 months ago (2016-03-10 01:28:34 UTC) #2
Oliver Chang
lgtm
4 years, 9 months ago (2016-03-10 01:33:28 UTC) #3
Tom Sepez
4 years, 9 months ago (2016-03-10 01:37:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
99406198ac4921a53425edc73cac67e7b4760895 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698