core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp - Issue 1780063003: Move ScopedSetInsertion to third_party/base/stl_util.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp

Issue 1780063003: Move ScopedSetInsertion to third_party/base/stl_util.h (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp b/core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp

index 675eec8f3a00321b5f987bed737738fcda8d6ed4..45d29f93512f87abbbb1c7857d8f944b2e17f413 100644

--- a/core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp

+++ b/core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp

@@ -1150,8 +1150,8 @@ CPDF_Object* CPDF_Parser::ParseIndirectObject(

// Prevent circular parsing the same object.

if (pdfium::ContainsKey(m_ParsingObjNums, objnum))

return nullptr;

- ScopedSetInsertion<FX_DWORD> local_insert(&m_ParsingObjNums, objnum);

+ pdfium::ScopedSetInsertion<FX_DWORD> local_insert(&m_ParsingObjNums, objnum);

if (GetObjectType(objnum) == 1 || GetObjectType(objnum) == 255) {

FX_FILESIZE pos = m_ObjectInfo[objnum].pos;

if (pos <= 0)