Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 178003010: Make an IdlCompiler class (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive, terry
Visibility:
Public.

Description

Make an IdlCompiler class Refactoring CL, inspired by and preliminary to Terry's "speed up r-b-t" CL. This adds a thin wrapper class, IdlCompiler, which has two methods: * Initialization (both IdlReader and CodeGeneratorV8) * .compile() The resulting main() is v. simple (clear initialization/compile); this will also make Terry's CL considerably simpler and easier to review, since he can just instantiate this class in r-b-t and call it repeatedly. Terry's: Faster PYTHON IDL dependency computation and parsing. https://codereview.chromium.org/169743005/ R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -15 lines) Patch
M Source/bindings/scripts/idl_compiler.py View 2 chunks +27 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nils Barth (inactive)
Quick refactoring CL.
6 years, 9 months ago (2014-03-03 06:39:25 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-03-03 06:41:52 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-03 06:48:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/178003010/1
6 years, 9 months ago (2014-03-03 06:48:37 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 09:45:44 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24356
6 years, 9 months ago (2014-03-03 09:45:45 UTC) #6
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-03 23:43:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/178003010/1
6 years, 9 months ago (2014-03-03 23:44:17 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 23:44:38 UTC) #9
Message was sent while issue was closed.
Change committed as 168340

Powered by Google App Engine
This is Rietveld 408576698